You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2012/09/14 17:20:08 UTC

[jira] [Created] (LUCENE-4389) Fix TwoDoubles dateline support

David Smiley created LUCENE-4389:
------------------------------------

             Summary: Fix TwoDoubles dateline support
                 Key: LUCENE-4389
                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
             Project: Lucene - Core
          Issue Type: Improvement
          Components: modules/spatial
            Reporter: David Smiley
             Fix For: 4.0


The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (LUCENE-4389) Fix TwoDoubles dateline support

Posted by "David Smiley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley reassigned LUCENE-4389:
------------------------------------

    Assignee: David Smiley
    
> Fix TwoDoubles dateline support
> -------------------------------
>
>                 Key: LUCENE-4389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>
> The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4389) Fix TwoDoubles dateline support

Posted by "David Smiley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-4389:
---------------------------------

    Attachment: LUCENE-4389_Support_dateline_and_circles_for_TwoDoubles.patch

Here's a working patch. It depends on LUCENE-4208 being applied already.  The dateline is fixed *and* it _brings back circle query shape support_.  Circle support had been removed temporarily in LUCENE-4208 and it's working now.  FYI TwoDoublesStrategy is primarily tested by PortedSolr3Test at the moment.
                
> Fix TwoDoubles dateline support
> -------------------------------
>
>                 Key: LUCENE-4389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4389_Support_dateline_and_circles_for_TwoDoubles.patch, LUCENE-4389 Support dateline for TwoDoubles.patch
>
>
> The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4389) Fix TwoDoubles dateline support

Posted by "Chris Male (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456405#comment-13456405 ] 

Chris Male commented on LUCENE-4389:
------------------------------------

I have faith in your knowledge on this and there seems to be adequate testing, so lets go ahead and commit that.
                
> Fix TwoDoubles dateline support
> -------------------------------
>
>                 Key: LUCENE-4389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4389_Support_dateline_and_circles_for_TwoDoubles.patch, LUCENE-4389 Support dateline for TwoDoubles.patch
>
>
> The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-4389) Fix TwoDoubles dateline support

Posted by "David Smiley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved LUCENE-4389.
----------------------------------

    Resolution: Fixed

Committed to trunk r1385130 and 4x r1385131
                
> Fix TwoDoubles dateline support
> -------------------------------
>
>                 Key: LUCENE-4389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4389_Support_dateline_and_circles_for_TwoDoubles.patch, LUCENE-4389 Support dateline for TwoDoubles.patch
>
>
> The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4389) Fix TwoDoubles dateline support

Posted by "David Smiley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-4389:
---------------------------------

    Attachment: LUCENE-4389 Support dateline for TwoDoubles.patch

This patch includes the dateline fix but some other code that I'll remove or change in makeFilter() -- it doesn't compile.  I really need to see LUCENE-4208 fixed first.  Then I can also add tests or enable existing tests to use this one.
                
> Fix TwoDoubles dateline support
> -------------------------------
>
>                 Key: LUCENE-4389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4389
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4389 Support dateline for TwoDoubles.patch
>
>
> The dateline support can easily be fixed.  After this, the TwoDoublesStrategy might not be particularly useful but at least it won't be buggy if you stay with Rectangle query shapes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org