You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/04/19 01:09:01 UTC

[GitHub] [incubator-heron] thinker0 opened a new pull request #3513: Add cppunit-devel for centos Dockerfile

thinker0 opened a new pull request #3513: Add cppunit-devel for centos Dockerfile
URL: https://github.com/apache/incubator-heron/pull/3513
 
 
   Add cppunit-devel for centos Dockerfile

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw merged pull request #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
nwangtw merged pull request #3513: Add cppunit-devel for Bazel 3
URL: https://github.com/apache/incubator-heron/pull/3513
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on issue #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
nwangtw commented on issue #3513: Add cppunit-devel for Bazel 3
URL: https://github.com/apache/incubator-heron/pull/3513#issuecomment-616203623
 
 
   No worries. It happens. :)
   
   On Sun, Apr 19, 2020 at 10:12 AM Nicholas Nezis <no...@github.com>
   wrote:
   
   > Sorry. I should have verified each of the Docker images. I only checked
   > Ubuntu 18 and Debian 10.
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-heron/pull/3513#issuecomment-616185679>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABQPBH25IZS7ZG76QIP4UHDRNMWGVANCNFSM4MLSSWHQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
nwangtw commented on a change in pull request #3513: Add cppunit-devel for Bazel 3
URL: https://github.com/apache/incubator-heron/pull/3513#discussion_r410946205
 
 

 ##########
 File path: docker/compile/Dockerfile.centos7
 ##########
 @@ -36,6 +36,7 @@ RUN yum -y install \
       make \
       patch \
       python-devel \
+      cppunit-devel \
 
 Review comment:
   I got the same error. Thx for the fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nicknezis commented on issue #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
nicknezis commented on issue #3513: Add cppunit-devel for Bazel 3
URL: https://github.com/apache/incubator-heron/pull/3513#issuecomment-616185679
 
 
   Sorry. I should have verified each of the Docker images. I only checked Ubuntu 18 and Debian 10.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] thinker0 commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile

Posted by GitBox <gi...@apache.org>.
thinker0 commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile
URL: https://github.com/apache/incubator-heron/pull/3513#discussion_r410830777
 
 

 ##########
 File path: docker/compile/Dockerfile.centos7
 ##########
 @@ -36,6 +36,7 @@ RUN yum -y install \
       make \
       patch \
       python-devel \
+      cppunit-devel \
 
 Review comment:
   We use centos7, but the following build error occurs.
   
   I think it will be necessary for other os.
   
   ```
   sh ./scripts/ci/build_release_packages.sh 0.20.3-incubating-rc2 centos7 ./artifacts
   
   
   ERROR: /root/.cache/bazel/_bazel_root/c481f31d0aff7f9fd86654fb84c9a629/external/org_apache_zookeeper/BUILD.bazel:7:1: Executing genrule @org_apache_zookeeper//:zookeeper-srcs failed (Exit 1): bash failed: error executing command
     (cd /root/.cache/bazel/_bazel_root/c481f31d0aff7f9fd86654fb84c9a629/execroot/org_apache_heron && \
     exec env - \
       PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin \
     /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; export INSTALL_DIR=$(pwd)/bazel-out/k8-opt/bin/external/org_apache_zookeeper
   export TMP_DIR=$(mktemp -d -t zookeeper.XXXXX)
   export CXXFLAGS=-Wno-error
   export CFLAGS=-Wno-error
   mkdir -p $TMP_DIR
   cp -R $(pwd)/external/org_apache_zookeeper/* $TMP_DIR
   cd $TMP_DIR/zookeeper-client/zookeeper-client-c
   autoreconf -if
   ./configure --prefix=$INSTALL_DIR --enable-shared=no
   make install
   rm -rf $TMP_DIR')
   configure: error: Package requirements (cppunit >= 1.10.2) were not met:
   No package 'cppunit' found
   Consider adjusting the PKG_CONFIG_PATH environment variable if you
   installed software in a non-standard prefix.
   Alternatively, you may set the environment variables CPPUNIT_CFLAGS
   and CPPUNIT_LIBS to avoid the need to call pkg-config.
   See the pkg-config man page for more details.
   libtoolize: putting auxiliary files in `.'.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile

Posted by GitBox <gi...@apache.org>.
nwangtw commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile
URL: https://github.com/apache/incubator-heron/pull/3513#discussion_r410830100
 
 

 ##########
 File path: docker/compile/Dockerfile.centos7
 ##########
 @@ -36,6 +36,7 @@ RUN yum -y install \
       make \
       patch \
       python-devel \
+      cppunit-devel \
 
 Review comment:
   Only needed by centos7? What is the error you got?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile

Posted by GitBox <gi...@apache.org>.
nwangtw commented on a change in pull request #3513: Add cppunit-devel for centos Dockerfile
URL: https://github.com/apache/incubator-heron/pull/3513#discussion_r410832489
 
 

 ##########
 File path: docker/compile/Dockerfile.centos7
 ##########
 @@ -36,6 +36,7 @@ RUN yum -y install \
       make \
       patch \
       python-devel \
+      cppunit-devel \
 
 Review comment:
   kk. Thx.
   
   Let me try. Maybe bazel 3 requires newer things than 0.26.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] thinker0 commented on issue #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
thinker0 commented on issue #3513:
URL: https://github.com/apache/incubator-heron/pull/3513#issuecomment-616282479


   @nicknezis <https://github.com/nicknezis> We put some streaming in
   production and it works fine.
   
   2020년 4월 20일 (월) 오전 9:02, Josh Fischer <no...@github.com>님이 작성:
   
   > @nicknezis <https://github.com/nicknezis> No worries at all. That's what
   > the community is for.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-heron/pull/3513#issuecomment-616247757>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AACXLGN7QTDHKNY5YREJFMTRNOGI5ANCNFSM4MLSSWHQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on issue #3513: Add cppunit-devel for Bazel 3

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on issue #3513:
URL: https://github.com/apache/incubator-heron/pull/3513#issuecomment-616247757


   @nicknezis No worries at all.  That's what the community is for.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org