You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/30 11:38:51 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

ustcweizhou opened a new pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854
 
 
   
   
   ## Description
   <!--- Describe your changes in detail -->
   
   Fixes #3817 #3841 
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582826234
 
 
   Sure @ustcweizhou cc @andrijapanicsb @DaanHoogland 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582261852
 
 
   Ping @ustcweizhou ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580415992
 
 
   > lgtm, but i think we want this on 4.13
   
   yes, we do need.
   After this get merged, I will create another PR , so we do not need to avoid review twice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580630744
 
 
   @DaanHoogland @GabrielBrascher 
   I understand your concerns.
   due to #3371 which only exist in master not 4.13, there are some conflicts when forward merge 4.13 to master
   
   @DaanHoogland can you cherry pick #3371  from master to 4.13 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582357301
 
 
   > @ustcweizhou can you also check in 4.13, the changes in centos6's spec?
   > @blueorangutan package
   
   @rhtyd do we still support centos6 ? I do not have a centos6 env

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582364112
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-754

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582357690
 
 
   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580339371
 
 
   lgtm, but i think we want this on 4.13

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] GabrielBrascher commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580531144
 
 
   @DaanHoogland @ustcweizhou it might be easier to target this one into 4.13 and then forward it to 4.14, instead of opening two PRs. What do you think of targeting this PR to 4.13?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580647858
 
 
   @DaanHoogland a0efbf9 and e93f6bf <- does this has an affect on the current PR or do you want to cherry pick it for dependency?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache closed pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582748765
 
 
   @ustcweizhou in master/4.14 we won't but in 4.13 we still support centos6 (see `packaging/centos63/` in your 4.13 branch)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580639662
 
 
   > the conflict are the deps 'gawk, iproute2', I have no idea if these are needed in 4.13. Need to look so procrastinating....
   
   oh, yes, this commit e93f6bf3c2d3f037e659c87a3a0ba474a734d8c6 only exist in master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-583090429
 
 
   > @rhtyd @weizhouapache are we merging this as is?
   
   I am ok with it.
   but you know, I am the author of this PR .....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580668353
 
 
   @ustcweizhou can you simply close this and open a PR against 4.13 including the changes to add/support gawk and iproute2 dependencies?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580621930
 
 
   I agree with @GabrielBrascher , @weizhouapache. i've been forward merging all 4.13 PRs so far, so we only review once.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580642554
 
 
   tnx @weizhouapache. @rhtyd @GabrielBrascher I can cherry pick both those commits without conflicts: e93f6bf3c2d3f037e659c87a3a0ba474a734d8c6 and a0efbf9d09e57a907cd599d28a1def02686240f1 . Shall we and than ask @weizhouapache to base this on 4.13 and run regression?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-583075563
 
 
   @rhtyd @weizhouapache are we merging this as is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd merged pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580631490
 
 
   ohw, that is a revert and a revert of a revert... will have a look @weizhouapache , but you might be right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580642554
 
 
   tnx @weizhouapache. @rhtyd @GabrielBrascher I can cherry pick both those commits without conflicts: e93f6bf3c2d3f037e659c87a3a0ba474a734d8c6 and a0efbf9d09e57a907cd599d28a1def02686240f1 . Shall we and than ask @weizhouapache to base this on 4.13 and run regression?
   /cc @andrijapanicsb 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582317719
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-750

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-583241958
 
 
   I'm okay with doc notes. @ustcweizhou please send a PR to apache/cloudstack-documentation or @andrijapanicsb please keep a note. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582794444
 
 
   @rhtyd 
   python-pip and python-dns are part of EPEL for centos6
   I would suggest to add the fix in cloudstack document
   ```
   sudo yum install epel-release
   sudo yum -y install python-dns
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582310085
 
 
   @ustcweizhou can you also check in 4.13, the changes in centos6's spec?
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582310243
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-583242270
 
 
   Checked the centos7 dependencies names are correct, packaging is OK. Explicit smoketests are not necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache edited a comment on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580630744
 
 
   @DaanHoogland @GabrielBrascher 
   I understand your concerns.
   due to #3371 which only exist in master not 4.13, there are some conflicts when forward merge 4.13 to master if this PR is merged into 4.13
   
   @DaanHoogland can you cherry pick #3371  from master to 4.13 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854
 
 
   
   
   ## Description
   <!--- Describe your changes in detail -->
   
   Fixes #3817 #3841 
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-582301940
 
 
   rebased with 4.13 instead of master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3854: Install python-dnspython or python-dns to fix issue with cloudstack-setup-management
URL: https://github.com/apache/cloudstack/pull/3854#issuecomment-580635212
 
 
   the conflict are the deps 'gawk, iproute2', I have no idea if these are needed in 4.13. Need to look so procrastinating....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services