[jira] [Updated] (HIVE-2832) Cache error messages for additional logging

["Phabricator (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2832:
------------------------------

    Attachment: HIVE-2832.D2025.1.patch

kevinwilfong requested code review of "HIVE-2832 [jira] Cache error messages for additional logging".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2832

  Created a subclass of PrintStream which stores output written to its println method in a variable (in particular this will store all output written to the LogHelper class's printError method.  I also created a new variable info in SessionState which, if set, will be used by LogHelper's printInfo method instead of SessionState.err, as logs written using this method aren't as significant.

  It would be good if we could cache logs written to SessionState.err so that they could be exposed to hooks for additional logging.  This would allow logging of error messages with the queries that failed in a central location.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2025

AFFECTED FILES
  common/src/java/org/apache/hadoop/hive/common/io/CachingPrintStream.java
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
  ql/src/test/results/clientnegative/cachingprintstream.q.out
  ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyCachingPrintStreamHook.java
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
  ql/src/test/queries/clientnegative/cachingprintstream.q
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/4341/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Cache error messages for additional logging
> -------------------------------------------
>
>                 Key: HIVE-2832
>                 URL: https://issues.apache.org/jira/browse/HIVE-2832
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Kevin Wilfong
>         Attachments: HIVE-2832.D2025.1.patch
>
>
> It would be good if we could cache logs written to SessionState.err so that they could be exposed to hooks for additional logging.  This would allow logging of error messages with the queries that failed in a central location.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira