You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/06/16 15:00:13 UTC
[GitHub] [submarine] litmus-zhang opened a new pull request, #967: submarine-workbench-v2 - Frontend
litmus-zhang opened a new pull request, #967:
URL: https://github.com/apache/submarine/pull/967
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Improvement
### Todos
* [
* Created the components of the experiment page
* ] - Task
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
* https://issues.apache.org/jira/browse/SUBMARINE-1237
-->
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)

### Questions:
* Do the license files need updating? Yes/No
* Are there breaking changes for older versions? Yes/No
* Does this need new documentation? Yes/No No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] litmus-zhang commented on pull request #967: submarine-workbench-v2 - Frontend
Posted by GitBox <gi...@apache.org>.
litmus-zhang commented on PR #967:
URL: https://github.com/apache/submarine/pull/967#issuecomment-1166286338
Oh I was worried about the license, I will fix that today
On Sat, Jun 25, 2022, 14:26 kuanhsun ***@***.***> wrote:
> ***@***.**** requested changes on this pull request.
>
> @litmus-zhang <https://github.com/litmus-zhang> Here are some requests,
> thanks.
>
> 1. All of the files required a Licence comment on the top.
> 2. Also, fix the test.
> Others, LGTM.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/submarine/pull/967#pullrequestreview-1019308328>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJUY2ZD2CKAHUAWYUIIM2BDVQ4CHNANCNFSM5Y7DI2FQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] submarine-workbench-v2 - Frontend [submarine]
Posted by "litmus-zhang (via GitHub)" <gi...@apache.org>.
litmus-zhang closed pull request #967: submarine-workbench-v2 - Frontend
URL: https://github.com/apache/submarine/pull/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #967: submarine-workbench-v2 - Frontend
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #967:
URL: https://github.com/apache/submarine/pull/967#issuecomment-1161260000
# [Codecov](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#967](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (491b6e2) into [master](https://codecov.io/gh/apache/submarine/commit/2a994f11ca81d919599efac0d4a68fef87044058?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a994f1) will **decrease** coverage by `15.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #967 +/- ##
=============================================
- Coverage 26.65% 11.41% -15.24%
- Complexity 53 814 +761
=============================================
Files 34 250 +216
Lines 709 24860 +24151
Branches 57 3561 +3504
=============================================
+ Hits 189 2839 +2650
- Misses 498 21844 +21346
- Partials 22 177 +155
```
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...se/workbench/utils/CustomJsonDateDeserializer.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItZGF0YWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvZGF0YWJhc2Uvd29ya2JlbmNoL3V0aWxzL0N1c3RvbUpzb25EYXRlRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/submarine/server/api/workbench/Action.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvc2VydmVyL2FwaS93b3JrYmVuY2gvQWN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/submarine/server/api/workbench/Role.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvc2VydmVyL2FwaS93b3JrYmVuY2gvUm9sZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...marine/server/utils/gson/NotebookIdSerializer.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci91dGlscy9nc29uL05vdGVib29rSWRTZXJpYWxpemVyLmphdmE=) | `50.00% <0.00%> (ø)` | |
| [...database/workbench/entity/SysDeptSelectEntity.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItZGF0YWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvZGF0YWJhc2Uvd29ya2JlbmNoL2VudGl0eS9TeXNEZXB0U2VsZWN0RW50aXR5LmphdmE=) | `36.36% <0.00%> (ø)` | |
| [...e/server/submitter/k8s/model/common/Configmap.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9jb21tb24vQ29uZmlnbWFwLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/submarine/commons/cluster/ClusterServer.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL0NsdXN0ZXJTZXJ2ZXIuamF2YQ==) | `57.82% <0.00%> (ø)` | |
| [...e/submarine/serve/seldon/SeldonDeploymentList.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvc2VydmUvc2VsZG9uL1NlbGRvbkRlcGxveW1lbnRMaXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/database/workbench/entity/TeamMemberEntity.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItZGF0YWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvZGF0YWJhc2Uvd29ya2JlbmNoL2VudGl0eS9UZWFtTWVtYmVyRW50aXR5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../submarine/server/manager/ModelVersionManager.java](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9tYW5hZ2VyL01vZGVsVmVyc2lvbk1hbmFnZXIuamF2YQ==) | `45.56% <0.00%> (ø)` | |
| ... and [206 more](https://codecov.io/gh/apache/submarine/pull/967/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2a994f1...491b6e2](https://codecov.io/gh/apache/submarine/pull/967?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org