You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/06 08:40:52 UTC
[GitHub] [maven-site] waldyrious opened a new pull request #257: run.md: change example to use the "compile" phase
waldyrious opened a new pull request #257:
URL: https://github.com/apache/maven-site/pull/257
"package" could be misunderstood by a newcomer to be a placeholder for the name of a package.
Using "compile" instead reduces the chances of ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-916731454
I prefer `clean verify` to complete tests, not to install or package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-917065645
@waldyrious Muito obrigado!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] waldyrious commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
waldyrious commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-917045041
Ok, updated with the changes discussed above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] waldyrious commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
waldyrious commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-916928861
Well, in [Introduction to the Build Lifecycle § Usual Command Line Calls](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#usual-command-line-calls) there's this passage:
> If you are uncertain what you want, the preferred phase to call is
>
> `mvn verify`
So perhaps it would be good to use `verify` in this example as well, for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-916652022
running only `compile` phase is not usable for me ... so it is not `typical` ... maybe `test` will be more `typical` ...
but it is only my opinion and my habit - so i can be wrong in this subject
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-917007266
>
>
> Well, in [Introduction to the Build Lifecycle § Usual Command Line Calls](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#usual-command-line-calls) there's this passage:
>
> > If you are uncertain what you want, the preferred phase to call is
> > `mvn verify`
>
> So perhaps it would be good to use `verify` in this example as well, for consistency?
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o merged pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
michael-o merged pull request #257:
URL: https://github.com/apache/maven-site/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] waldyrious commented on pull request #257: run.md: change example to use the "compile" phase
Posted by GitBox <gi...@apache.org>.
waldyrious commented on pull request #257:
URL: https://github.com/apache/maven-site/pull/257#issuecomment-916427048
@michael-o thanks for merging my other PRs! Any chance you could take a look at this one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org