You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2016/06/18 14:44:05 UTC

[jira] [Reopened] (BCEL-237) non-empty final arrays should be private as they are mutable

     [ https://issues.apache.org/jira/browse/BCEL-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb reopened BCEL-237:
-----------------------

It was not fixed; the code was reverted as part of reverting some non-compatible changes

> non-empty final arrays should be private as they are mutable
> ------------------------------------------------------------
>
>                 Key: BCEL-237
>                 URL: https://issues.apache.org/jira/browse/BCEL-237
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 6.0
>
>
> Final array elements are not themselves final.
> So any final arrays should always be private, otherwise external code can corrupt the entries accidentally or deliberately.
> Either the array can be accessed through a getter that clones the contents, or the entries can be accessed through a getter that returns a single entry.
> This issue affects:
> Constants.class:
> CONSTANT_NAMES
> ACCESS_NAMES
> INTERFACES_IMPLEMENTED_BY_ARRAYS
> TYPE_NAMES
> CLASS_TYPE_NAMES
> SHORT_TYPE_NAMES
> NO_OF_OPERANDS
> TYPE_OF_OPERANDS
> OPCODE_NAMES
> CONSUME_STACK
> PRODUCE_STACK
> ATTRIBUTE_NAMES
> ITEM_NAMES
> METHODHANDLE_NAMES



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)