You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tobwiens <gi...@git.apache.org> on 2014/07/09 16:08:51 UTC
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
GitHub user tobwiens opened a pull request:
https://github.com/apache/incubator-flink/pull/67
[FLINK-827] KeySelector- Example
Adding an example word count example which uses KeySelectors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tobwiens/incubator-flink FLINK-827-FIX-rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 15f83c871299e0eb4cc60d6efea4f1d74cc9e852
Author: TobiasWiens <to...@gmail.com>
Date: 2014-07-09T14:04:16Z
[FLINK-827] KeySelector- Example
Adding an example word count example which uses KeySelectors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-64379195
Agree with @aljoscha .
At some point we might even deprecate the key selectors. After all, you can always do the same thing by calling map to Tuple-2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-48714639
Looks good to me. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-64450880
I will ping @tobwiens to close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-64451774
No problem. It's an issue with the Apache GitHub setup. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-63958246
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-63957609
I would actually not add this example. There is a plethora of WordCounts in there already, and this seems to me to confuse with respect to whether you should use a POJO with expression key, or a key selector...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-64368523
Yes, I would like to encourage people to not use the KeySelectors. The implementation is cumbersome and expressions already provide good performance and should only get better once we have generated code for expression comparators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by tobwiens <gi...@git.apache.org>.
Github user tobwiens commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-64451590
Sorry did not know that I have to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-827] KeySelector- Example
Posted by tobwiens <gi...@git.apache.org>.
Github user tobwiens closed the pull request at:
https://github.com/apache/incubator-flink/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---