You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by bollinger <gi...@git.apache.org> on 2016/11/19 22:36:01 UTC

[GitHub] wicket pull request #192: Make websocket messages seriaizable.

GitHub user bollinger opened a pull request:

    https://github.com/apache/wicket/pull/192

    Make websocket messages seriaizable.

    The web socket ConnectedMessage was not serializable.
    Pages using WebSocketBehavior that stored the ConnectedMessage were therefore not serializable.
    
    This patch makes all known AbstractClientMessage classes serialiazable, and tests this.
    
    Scala to java makes me swear.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bollinger/wicket master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit 4a09d2a64c62946517bafbdf37349375bfe4a5aa
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-02-12T09:12:24Z

    Removed conflict marker from comment.

commit 59855ac795a178914be5b35ff1871edd059b7976
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-07-08T08:21:22Z

    Merge remote-tracking branch 'upstream/master'

commit 29a0d0927ba738bd0ccc6bc807a7ff07220bb31a
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-07-08T09:59:40Z

    BugFix: Ajax add header style sheet link mangles it.

commit e9ed025fe19ff2e892a06a49176593ebee0d4591
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-10-21T07:15:28Z

    Merge remote-tracking branch 'upstream/master'

commit 9b96962bb286947086cddbc6c796771b2b9fc021
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-11-19T15:57:37Z

    Merge remote-tracking branch 'upstream/master'

commit d92826e414b22141cc04b9104c1b9ad7eff3ddde
Author: Peter Henderson <pe...@starjar.com>
Date:   2016-11-19T22:17:17Z

    Web socket messages are now serializable.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #192: Make websocket messages seriaizable.

Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:

    https://github.com/apache/wicket/pull/192
  
    Thanks for the PR, @bollinger !
    But I have already improved this. I've answered one more time to the discussion at users@ with a link to the ticket in JIRA.
    Sorry for the extra swears I've caused! :-)
    
    Please check the current implementation by following the links in the ticket and close this PR if everything is good!
    Thank you and sorry once again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #192: Make websocket messages seriaizable.

Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:

    https://github.com/apache/wicket/pull/192
  
    Please close the PR!
    We do not own this repo. It is just a mirror of the Apache one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #192: Make websocket messages seriaizable.

Posted by bollinger <gi...@git.apache.org>.
Github user bollinger commented on the issue:

    https://github.com/apache/wicket/pull/192
  
    No worries. :-)
    
    The PR may not be accepted> But I've "Stubbed my toe" on Github/PR/java/wicket internals. 
    I'll be faster on the next one!
    
    Thanks
    
    Peter.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request #192: Make websocket messages seriaizable.

Posted by bollinger <gi...@git.apache.org>.
Github user bollinger closed the pull request at:

    https://github.com/apache/wicket/pull/192


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---