[GitHub] [cloudstack] rhtyd commented on a change in pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#discussion_r485970156



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2475,6 +2475,21 @@ public Network doInTransaction(final TransactionStatus status) {
         return network;
     }
 
+    /**
+     * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
+     * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
+     */
+    protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
+        if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {

Review comment:
       @GabrielBrascher Should we check if `pNtwk` is null? This could potentially cause a NPE; and the getIsolationMethods() is also a valid list with at least one item




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org