You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cygnusdark (via GitHub)" <gi...@apache.org> on 2023/06/28 04:19:51 UTC
[GitHub] [doris-flink-connector] cygnusdark opened a new pull request, #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
cygnusdark opened a new pull request, #155:
URL: https://github.com/apache/doris-flink-connector/pull/155
# Proposed changes
Issue Number: close #154
## Problem Summary:
Bump Flink CDC MySQL Connector version to 2.4.0
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: No
4. Does it need to update dependencies: Yes
5. Are there any changes that cannot be rolled back: No
## Further comments
I carefully tested and have re-deployed half of our online streaming ETL jobs using the newest Flink CDC 2.4 framework, which look good so far, except this issue: https://github.com/ververica/flink-cdc-connectors/issues/2243
The new feature of mysql connector that allows our job to automatically close idle readers has some problems when a single job syncs multiple tables and later we add new tables in sync list.
However, this feature looks good when you just want to sync single table. It will automatically release idle resources after snapshot reading done.
@JNSimba @DongLiang-0 anyone can help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] cygnusdark commented on pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "cygnusdark (via GitHub)" <gi...@apache.org>.
cygnusdark commented on PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155#issuecomment-1674315417
Please check again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] JNSimba commented on pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155#issuecomment-1667501057
Thank you for your contribution, it has been upgraded to 2.4.1, please resolve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] cygnusdark commented on pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "cygnusdark (via GitHub)" <gi...@apache.org>.
cygnusdark commented on PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155#issuecomment-1667536433
The conflict has been resolved. Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155#discussion_r1290827816
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/MysqlDatabaseSync.java:
##########
@@ -21,6 +21,7 @@
import com.ververica.cdc.connectors.mysql.source.config.MySqlSourceOptions;
import com.ververica.cdc.connectors.mysql.source.offset.BinlogOffset;
import com.ververica.cdc.connectors.mysql.source.offset.BinlogOffsetBuilder;
+import com.ververica.cdc.debezium.utils.JdbcUrlUtils;
Review Comment:
please remove this import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155#discussion_r1290827816
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/MysqlDatabaseSync.java:
##########
@@ -21,6 +21,7 @@
import com.ververica.cdc.connectors.mysql.source.config.MySqlSourceOptions;
import com.ververica.cdc.connectors.mysql.source.offset.BinlogOffset;
import com.ververica.cdc.connectors.mysql.source.offset.BinlogOffsetBuilder;
+import com.ververica.cdc.debezium.utils.JdbcUrlUtils;
Review Comment:
please remove unuse import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris-flink-connector] JNSimba merged pull request #155: [Improvement] Bump Flink CDC MySQL Connector version to 2.4.0 (#154)
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #155:
URL: https://github.com/apache/doris-flink-connector/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org