[jira] [Comment Edited] (SLING-4206) [Sightly Engine] Refactor the Sightly Engine API

["Radu Cotescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227800#comment-14227800 ] 

Radu Cotescu edited comment on SLING-4206 at 11/27/14 4:25 PM:
---------------------------------------------------------------

I've attached the patch from the mentioned fork. There are multiple internal changes, but the issue's description best summarises what we've done.

The only exported API, for now, is

{noformat}
org.apache.sling.scripting.sightly
├── Record.java
├── ResourceResolution.java
├── SightlyException.java
├── extension
│   ├── ExtensionInstance.java
│   ├── RuntimeExtension.java
│   └── RuntimeExtensionException.java
├── pojo
│   └── Use.java
├── render
│   └── RenderContext.java
└── use
    ├── ProviderOutcome.java
    ├── SightlyUseException.java
    └── UseProvider.java
{noformat}

The patch can be applied with {{git apply SLING-4206.patch}} or with {{patch -p1 < SLING-4206.patch}}.


was (Author: radu.cotescu):
I've attached the patch from the mentioned fork. There are multiple internal changes, but the issue's description best summarises what we've done.

The only exported API, for now, is

{noformat}
org.apache.sling.scripting.sightly
├── Record.java
├── ResourceResolution.java
├── SightlyException.java
├── extension
│   ├── ExtensionInstance.java
│   ├── RuntimeExtension.java
│   └── RuntimeExtensionException.java
├── pojo
│   └── Use.java
├── render
│   └── RenderContext.java
└── use
    ├── ProviderOutcome.java
    ├── SightlyUseException.java
    └── UseProvider.java
{noformat}


> [Sightly Engine] Refactor the Sightly Engine API
> ------------------------------------------------
>
>                 Key: SLING-4206
>                 URL: https://issues.apache.org/jira/browse/SLING-4206
>             Project: Sling
>          Issue Type: Task
>            Reporter: Felix Meschberger
>             Fix For: Scripting Sightly Engine 1.0.0
>
>         Attachments: SLING-4206.patch
>
>
> The API of the Sightly Script Engine is currently exposing quite a number of classes which are not directly related in a single package:
> * Some classes and interfaces (e.g. BaseRenderUnit and RenderUnit) need not be exported at all
> * Interfaces should be split into separate packages reflecting the coherence:
> ** Extension API
> ** UseProvider API
> ** Use interface
> * ObjectModel currently contains a collection of methods which should not be exposed at all (operator implementations).
> Refactoring work has been done on a fork at https://github.com/fmeschbe/sling.git. This issue is to track bringing back these changes into Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)