[GitHub] [spark] juliuszsompolski commented on issue #25277: [WIP] Thriftserver support interval type

[GitBox <gi...@apache.org>]

juliuszsompolski commented on issue #25277: [WIP] Thriftserver support interval type
URL: https://github.com/apache/spark/pull/25277#issuecomment-523846918
 
 
   This has been filed as SPARK-28637. Could you update the PR description?
   If we want to return intervals as string, since Spark does not support actual Interval Year Month and Interval Day Second, then I think this PR is good to go.
   
   But then, I think maybe we should actually override GetTypeInfoOperation.
   Currently `!typeinfo` returns INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME, ARRAY, MAP, STRUCT, UNIONTYPE and USER_DEFINED, all of which Spark turns into string.
   Maybe we should make SparkGetTypeInfoOperation, to exclude types which we don't support?
   
   Then we would be missing only SparkGetCatalogsOperation, which we may add for completeness - e.g. for it to use the `HiveThriftServer2.listener` and show up in the UI.
   
   WDYT @wangyum ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org