You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by krlohnes <gi...@git.apache.org> on 2017/07/12 16:30:43 UTC
[GitHub] tinkerpop pull request #671: Add combined handler master
GitHub user krlohnes opened a pull request:
https://github.com/apache/tinkerpop/pull/671
Add combined handler master
@spmallette I think this is pretty much the cleanest I get history with the fixes etc needed for master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krlohnes/tinkerpop add_combined_handler_master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #671
----
commit c2643905ede89c2cb8580280dcf42ecfb4cdfe01
Author: Keith Lohnes <kr...@us.ibm.com>
Date: 2017-05-30T14:02:54Z
[TINKERPOP-915]Add combined handler for Http and Websockets
[TINKERPOP-915](https://issues.apache.org/jira/browse/TINKERPOP-915)
Most of this is tests. I added an integration test that goes over the
functionality of both the http and websocket channelizers using the new
`WsAndHttpChannelizer`. I added an additional test on top of that to
switch between using WebSockets and http.
The change itself leverages the existing `WebSocketChannelizer` to
provide the base pipeline setup. It has everything needed handler-wise
to service both http and ws connections. The
`WsAndHttpChannelizerHandler` then detects whether the incoming request
is a plain http connection or a WebSockets connection. If it's an http
connection, the channelizer handler swaps out the request handler
appropriately for whether or not authentication has been enabled.
commit cee56f527ad4975878a9ac866bc00a24b7fd3a88
Author: Keith Lohnes <kr...@us.ibm.com>
Date: 2017-07-12T15:35:17Z
Merge Combined WS and Http Channelizer to master
commit 325499c706c79c1fe5d0489e2bacbcf8fefa76c3
Author: Keith Lohnes <kr...@us.ibm.com>
Date: 2017-07-12T16:23:48Z
TINKERPOP-915 Fix issues from merging master
Removed generics on ServerExecutor in merge
Update HttpChannelizer integration tests to use new json format
Fix issues created from merging tp32 in 960fde1 regarding creation of
the authenticationHandler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #671: Add combined handler master
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/671
merged - thanks for solving the master merge issues and getting everything working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #671: Add combined handler master
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/671
lgtm - as i mentioned, i don't think it can get much nicer than what you have here. i'll run some basic tests and get this all merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #671: Add combined handler master
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/671
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---