You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/02/21 00:44:41 UTC
[PR] chore: Add TPC-* queries to repo [datafusion-comet]
andygrove opened a new pull request, #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The benchmark scripts in `benchmarks/tpc` currently require the user to provide the queries. It is more convenient to add them to the repository.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Add query files.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562#issuecomment-3945798921
Thanks for the reviews @mbutrovich @comphead. I'll have the next PR up to day to add support for docker-compose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562#discussion_r2841771743
##########
benchmarks/tpc/queries/tpcds/q1.sql:
##########
@@ -0,0 +1,26 @@
+-- CometBench-DS query 1 derived from TPC-DS query 1 under the terms of the TPC Fair Use Policy.
+-- TPC-DS queries are Copyright 2021 Transaction Processing Performance Council.
+-- This query was generated at scale factor 1.
Review Comment:
we could try regenerating at different scale factors and do a diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562#discussion_r2841602768
##########
benchmarks/tpc/queries/tpcds/q1.sql:
##########
@@ -0,0 +1,26 @@
+-- CometBench-DS query 1 derived from TPC-DS query 1 under the terms of the TPC Fair Use Policy.
+-- TPC-DS queries are Copyright 2021 Transaction Processing Performance Council.
+-- This query was generated at scale factor 1.
Review Comment:
How hard is it to parameterize this in the future? I wonder what values change, considering we usually run SF100 or 1000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562#issuecomment-3945797059
> Thanks @andygrove one question though. One day we investigated with @mbutrovich efficiency of pregenerated queries and that time we got 40% of TPCDS queries returning no results which might affect benchmarks. We managed to improve the set to have on 18% of such queries.
>
> For this TPC* set how many of them return 0 rows?
> Thanks @andygrove one question though. One day we investigated with @mbutrovich efficiency of pregenerated queries and that time we got 40% of TPCDS queries returning no results which might affect benchmarks. We managed to improve the set to have on 18% of such queries.
>
> For this TPC* set how many of them return 0 rows?
I don't know. The goal for this PR is just to move them from `datafusion-benchmarks` to this repo so that we can include them in docker images for docker-compose and k8s without having dependency on another repo.
when I do the next benchmark run I will record how many rows are returned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Add TPC-* queries to repo [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3562:
URL: https://github.com/apache/datafusion-comet/pull/3562#issuecomment-3952365164
> > Thanks @andygrove one question though. One day we investigated with @mbutrovich efficiency of pregenerated queries and that time we got 40% of TPCDS queries returning no results which might affect benchmarks. We managed to improve the set to have on 18% of such queries.
> > For this TPC* set how many of them return 0 rows?
>
> > Thanks @andygrove one question though. One day we investigated with @mbutrovich efficiency of pregenerated queries and that time we got 40% of TPCDS queries returning no results which might affect benchmarks. We managed to improve the set to have on 18% of such queries.
> > For this TPC* set how many of them return 0 rows?
>
> I don't know. The goal for this PR is just to move them from `datafusion-benchmarks` to this repo so that we can include them in docker images for docker-compose and k8s without having dependency on another repo.
>
> when I do the next benchmark run I will record how many rows are returned
@comphead I created https://github.com/apache/datafusion-comet/pull/3582 to start recording row counts and result hashes when running benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org