You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/21 16:48:10 UTC
[GitHub] [incubator-iceberg] Fokko opened a new pull request #577: Add Java 11 to the testsuite
Fokko opened a new pull request #577:
URL: https://github.com/apache/incubator-iceberg/pull/577
Add JDK11 to the Travis build matrix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Fokko commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-616562633
@massdosage Thank you. I've just updated the PR :) I wanted to run against the RC as well, but the release got through so quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] massdosage commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
massdosage commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-616562111
Hive 2.3.7 was released over the weekend but I think you already notice! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617338734
Does it work to set the JVM target to Java 8 and still run in Java 11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Fokko commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617382811
I think this is already the case: https://github.com/apache/incubator-iceberg/blob/master/build.gradle#L82-L83
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] massdosage edited a comment on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
massdosage edited a comment on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-616562111
Hive 2.3.7 was released over the weekend but I think you already noticed! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Fokko commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617335541
Yes, looks like it: https://github.com/apache/spark/commit/3ed91c9b8998f2512716f906cd1cba25578111ff
We can't force it to ASM7, since it part of the package path: `import org.apache.xbean.asm7._`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617324747
Looks like Spark 2.4 doesn't support Java 11, according to [this thread about ASM 6/7](http://apache-spark-user-list.1001560.n3.nabble.com/java-lang-IllegalArgumentException-Unsupported-class-file-major-version-55-tt34546.html#a34548).
I think that's the current problem. Maybe we can try overriding ASM 6 with ASM 7, but we might just have to wait for a version of Spark that can work with Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Fokko commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617283502
Forgot to update the test dependencies, should be fixed now! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #577: Add Java 11 to the testsuite
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #577:
URL: https://github.com/apache/incubator-iceberg/pull/577#issuecomment-617275332
I added better logging for test failures in #945. I'm going to close and re-open this to trigger a new build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org