You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openserverless.apache.org by "d4rkstar (via GitHub)" <gi...@apache.org> on 2025/01/03 22:33:12 UTC
[PR] chore(operator): milvus 2.5.2 [openserverless-operator]
d4rkstar opened a new pull request, #38:
URL: https://github.com/apache/openserverless-operator/pull/38
upgraded milvus to v2.5.2. Upgraded pymilvus too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(operator): milvus 2.5.2 [openserverless-operator]
Posted by "francescotimperi (via GitHub)" <gi...@apache.org>.
francescotimperi commented on code in PR #38:
URL: https://github.com/apache/openserverless-operator/pull/38#discussion_r1903010581
##########
nuvolaris/milvus_admin_client.py:
##########
@@ -16,9 +16,10 @@
# under the License.
#
import logging
+
import nuvolaris.config as cfg
-import nuvolaris.util as util
-from pymilvus import MilvusClient, connections, db
+from nuvolaris.milvus_simple_client import MilvusSimpleClient as MilvusClient
+#from pymilvus import MilvusClient, connections, db
class MilvusAdminClient:
Review Comment:
why don't we remove commented import? There is always the GitHub history to eventually retrieve it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(operator): milvus 2.5.2 [openserverless-operator]
Posted by "francescotimperi (via GitHub)" <gi...@apache.org>.
francescotimperi merged PR #38:
URL: https://github.com/apache/openserverless-operator/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org