You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2010/07/28 18:32:16 UTC

[jira] Created: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
-----------------------------------------------------------------------------------------------------------

                 Key: SLING-1615
                 URL: https://issues.apache.org/jira/browse/SLING-1615
             Project: Sling
          Issue Type: Bug
          Components: JCR
    Affects Versions: JCR Contentloader 2.0.6
            Reporter: Ian Boston
             Fix For: JCR ContentLoader 2.0.8


If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
But if I do a normal Sling POST the node is created.
This is inconsistent and requires http clients to make 2 posts where one would have worked.

Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Edelson updated SLING-1615:
----------------------------------

        Fix Version/s: Servlets Post 2.0.6
                           (was: JCR ContentLoader 2.0.8)
    Affects Version/s:     (was: JCR Contentloader 2.0.6)
          Component/s: Servlets
                           (was: JCR)

> When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1615
>                 URL: https://issues.apache.org/jira/browse/SLING-1615
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>            Reporter: Ian Boston
>            Assignee: Ian Boston
>             Fix For: Servlets Post 2.0.6
>
>
> If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
> But if I do a normal Sling POST the node is created.
> This is inconsistent and requires http clients to make 2 posts where one would have worked.
> Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Resolved: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

Posted by Justin Edelson <ju...@gmail.com>.
Forgot to say that the patch looked ok to me.


On Jul 29, 2010, at 6:24 AM, "Ian Boston (JIRA)" <ji...@apache.org> wrote:

> 
>     [ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Ian Boston resolved SLING-1615.
> -------------------------------
> 
>    Resolution: Fixed
> 
> Applied patch having left for comments.
> passes build, integration tests and downstream integration tests with no impact.
> 
>> When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
>> -----------------------------------------------------------------------------------------------------------
>> 
>>                Key: SLING-1615
>>                URL: https://issues.apache.org/jira/browse/SLING-1615
>>            Project: Sling
>>         Issue Type: Bug
>>         Components: JCR
>>   Affects Versions: JCR Contentloader 2.0.6
>>           Reporter: Ian Boston
>>           Assignee: Ian Boston
>>            Fix For: JCR ContentLoader 2.0.8
>> 
>> 
>> If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
>> But if I do a normal Sling POST the node is created.
>> This is inconsistent and requires http clients to make 2 posts where one would have worked.
>> Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

[jira] Resolved: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Boston resolved SLING-1615.
-------------------------------

    Resolution: Fixed

Applied patch having left for comments.
passes build, integration tests and downstream integration tests with no impact.

> When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1615
>                 URL: https://issues.apache.org/jira/browse/SLING-1615
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Contentloader 2.0.6
>            Reporter: Ian Boston
>            Assignee: Ian Boston
>             Fix For: JCR ContentLoader 2.0.8
>
>
> If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
> But if I do a normal Sling POST the node is created.
> This is inconsistent and requires http clients to make 2 posts where one would have worked.
> Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Boston reassigned SLING-1615:
---------------------------------

    Assignee: Ian Boston

> When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1615
>                 URL: https://issues.apache.org/jira/browse/SLING-1615
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Contentloader 2.0.6
>            Reporter: Ian Boston
>            Assignee: Ian Boston
>             Fix For: JCR ContentLoader 2.0.8
>
>
> If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
> But if I do a normal Sling POST the node is created.
> This is inconsistent and requires http clients to make 2 posts where one would have worked.
> Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893281#action_12893281 ] 

Ian Boston commented on SLING-1615:
-----------------------------------

Since one solution to this is a large re-factor of ModifyOperation I have uploaded a patch set

http://codereview.appspot.com/1842048

It creates a new Abstract parent class for both Modify and Import operatons, moving all the create related methods into that parent and then reuses them in Import to create the node that the POST targets.

> When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-1615
>                 URL: https://issues.apache.org/jira/browse/SLING-1615
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Contentloader 2.0.6
>            Reporter: Ian Boston
>            Assignee: Ian Boston
>             Fix For: JCR ContentLoader 2.0.8
>
>
> If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results.
> But if I do a normal Sling POST the node is created.
> This is inconsistent and requires http clients to make 2 posts where one would have worked.
> Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.