[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1953: update jit-related dependencies

[GitBox <gi...@apache.org>]

yjshen commented on a change in pull request #1953:
URL: https://github.com/apache/arrow-datafusion/pull/1953#discussion_r821613750



##########
File path: datafusion-jit/src/jit.rs
##########
@@ -45,7 +45,7 @@ impl Default for JIT {
     #[cfg(target_arch = "x86_64")]
     fn default() -> Self {
         let builder = JITBuilder::new(cranelift_module::default_libcall_names());

Review comment:
       perhaps unwrap() on this line?

##########
File path: datafusion-jit/src/jit.rs
##########
@@ -99,7 +99,7 @@ impl JIT {
         });
         let isa = isa_builder.finish(settings::Flags::new(flag_builder));

Review comment:
       Same here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org