You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/21 13:23:07 UTC

[GitHub] [incubator-apisix] membphis commented on pull request #1871: bugfix: failed to get `host` in health check configuration.

membphis commented on pull request #1871:
URL: https://github.com/apache/incubator-apisix/pull/1871#issuecomment-661858517


   I check the source code, and I found two points.
   
   > the healthcheck was ignored
   
   1. if the count of upstream node is 1, it will return the upstream node directly, the healthcheck was ignored. 
   
   https://github.com/apache/incubator-apisix/blob/master/apisix/balancer.lua#L180-L185
   
   I think we can create a new PR to fix this bug first.
   
   > The health check prints the log only when the status of the upstream node is changed
   
   The default status is SUCCESS, if the status is SUCCESS always, we never can get a log like `healthy SUCCESS`. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org