You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/10/04 14:52:00 UTC

[jira] [Commented] (GEODE-7207) FIx Remaining LGTM "Error" level alerts

    [ https://issues.apache.org/jira/browse/GEODE-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944566#comment-16944566 ] 

ASF subversion and git services commented on GEODE-7207:
--------------------------------------------------------

Commit e1d52235cf2b3607e522c6c40aa81a4deb6f3ef2 in geode-native's branch refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=e1d5223 ]

GEODE-7207: Fix remaining LGTM "Error" level alerts (#526)

* GEODE-7207: Fix LGTM complaints
- Clean up FunctionExecutionTest
- Remove unneeded cast
- remove cast in UnitTestsN.cs
- remove unused servers_ variable
- use System conversion to double, rather than implicit cast
- Fix compilation error
- Convert numOps to double

Co-authored-by: Michael Oleske <mo...@pivotal.io>



> FIx Remaining LGTM "Error" level alerts
> ---------------------------------------
>
>                 Key: GEODE-7207
>                 URL: https://issues.apache.org/jira/browse/GEODE-7207
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> We're down to a manageable number of these now, it should be fairly short work to fix the remaining issues.
>  
> Acceptance criteria:
> When a PR is submitted and LGTM scans the code base, the report for this PR shows 12 alerts fixed, all of which are "error" level alerts, and no new alerts introduced.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)