You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "laimis (via GitHub)" <gi...@apache.org> on 2023/04/09 12:00:12 UTC
[GitHub] [lucenenet] laimis opened a new pull request, #813: BREAKING: remove virtual call from the constructor for Sort
laimis opened a new pull request, #813:
URL: https://github.com/apache/lucenenet/pull/813
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670
This one focuses on Sort. Creating a private method that constructor can call and calling the private method from the virtual method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] laimis merged pull request #813: BREAKING: remove virtual call from the constructor for Sort
Posted by "laimis (via GitHub)" <gi...@apache.org>.
laimis merged PR #813:
URL: https://github.com/apache/lucenenet/pull/813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org