You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2018/09/28 17:04:05 UTC
[GitHub] nlu90 commented on a change in pull request #3027: Update
python-doc-gen.sh
nlu90 commented on a change in pull request #3027: Update python-doc-gen.sh
URL: https://github.com/apache/incubator-heron/pull/3027#discussion_r221319759
##########
File path: website/scripts/python-doc-gen.sh
##########
@@ -20,9 +20,10 @@ set -e
HERONPY_VERSION=$1
HERON_ROOT_DIR=$(git rev-parse --show-toplevel)
INPUT=heronpy
-TMP_DIR=$(mktemp --directory)
+TMP_DIR=$(mktemp -d)
-VENV="$(mktemp --directory)"
+VENV="$(mktemp -d)"
+pip install virtualenv
Review comment:
Should we check if the `virtualenv` is already installed before using `pip install`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services