You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/04/13 09:52:45 UTC

[spark] branch master updated: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsIIOnConnect` for now

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d7c3bffe48 [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsIIOnConnect` for now
5d7c3bffe48 is described below

commit 5d7c3bffe48785addecca528bdd81a1374f00826
Author: Ruifeng Zheng <ru...@apache.org>
AuthorDate: Thu Apr 13 18:52:28 2023 +0900

    [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsIIOnConnect` for now
    
    ### What changes were proposed in this pull request?
    
    `TorchDistributorLocalUnitTestsIIOnConnect` was recently added in https://github.com/apache/spark/commit/f8751e2afeb5042a17d86763f965bc8f479784bf , but after that  `test_parity_torch_distributor` became unstable and sometime got stuck
    
    ### Why are the changes needed?
    to make CI happy, I file [SPARK-43122](https://issues.apache.org/jira/browse/SPARK-43122) to track it.
    
    ### Does this PR introduce _any_ user-facing change?
    No, test only
    
    ### How was this patch tested?
    CI
    
    Closes #40775 from zhengruifeng/torch_ignore_new_tests.
    
    Authored-by: Ruifeng Zheng <ru...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 python/pyspark/ml/tests/connect/test_parity_torch_distributor.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyspark/ml/tests/connect/test_parity_torch_distributor.py b/python/pyspark/ml/tests/connect/test_parity_torch_distributor.py
index b1b120f9254..2ce1f327ee5 100644
--- a/python/pyspark/ml/tests/connect/test_parity_torch_distributor.py
+++ b/python/pyspark/ml/tests/connect/test_parity_torch_distributor.py
@@ -75,7 +75,7 @@ class TorchDistributorLocalUnitTestsOnConnect(
         ]
 
 
-@unittest.skipIf(not have_torch, "torch is required")
+@unittest.skip("unstable, ignore for now")
 class TorchDistributorLocalUnitTestsIIOnConnect(
     TorchDistributorLocalUnitTestsMixin, unittest.TestCase
 ):


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org