[jira] Closed: (WICKET-3228) put reloading feature of ReloadingWicketFilter into WicketFilter

["Peter Ertl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl closed WICKET-3228.
------------------------------

    Resolution: Won't Fix

after enough -1 votes I decided to close this

> put reloading feature of ReloadingWicketFilter into WicketFilter
> ----------------------------------------------------------------
>
>                 Key: WICKET-3228
>                 URL: https://issues.apache.org/jira/browse/WICKET-3228
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>             Fix For: 1.5.1
>
>         Attachments: reloading.patch
>
>
> I would suggest to integration the functionality of ReloadingWicketFilter into WicketFilter.
>   Why?
> Usually when using ReloadingWicketFilter (which saves a large number of restarts *imho*) you need to maintain two web.xml files, one for development and one for deployment.
> By integrating the reload feature into WicketFilter the number of web.xml files you need to maintain would be reduced to one single file.
> This eliminates duplicate xml, e.g. when adding a new servlet you have to add it two both web.xml (which btw is against the DRY principle I strongly advocate)
> The included patch considers two ways of enabling the reload feature on wicket filter.
> 1st method (the lame way :-)
> ----------------------------
> You can plainly add an init parameter to your web.xml (this is the lame way, as you __still__ need two web.xml)
>   
>   <filter>
>     <filter-name>wicket</filter-name>
>     <filter-class>org.apache.wicket.protocol.http.WicketFilter</filter-class> 
>     <init-param>
>       <param-name>applicationClassName</param-name>
>       <param-value>my.great.WicketApplication</param-value>
>     </init-param>
>     <init-param>
>       <param-name>configuration</param-name>
>       <param-value>development</param-value>
>     </init-param>
>     <init-param>
>       <param-name>reloading</param-name>
>       <param-value>true</param-value>
>     </init-param>
>   </filter>
> 2nd method (the neat one)
> -------------------------
> your web.xml looks like this:
> <filter>
>   <filter-name>wicket</filter-name>
>   <filter-class>org.apache.wicket.protocol.http.WicketFilter</filter-class> 
>   <init-param>
>     <param-name>applicationClassName</param-name>
>     <param-value>my.great.WicketApplication</param-value>
>   </init-param>
> </filter>
> In you standlone jetty main() or your local web development server you set these properties:
>   - wicket.configuration = development (this already is supported by wicket)
>   - wicket.reloading = true (this comes with my patch)
> It's easy to set these globally on your development server or in your custom test runner.
> So there's no difference between web.xml for development and deployment and you don't need to configure maven to use an alternate web.xml for packaging (no fiddling around with maven plugins :-) or do some kind of substitution on the web.xml.
> The patch is short in simple *imho* and makes using wicket even simpler.
> Please let me know what you think :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.