You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/17 02:54:15 UTC

[GitHub] [apisix] gxthrj commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

gxthrj commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r489908479



##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -52,16 +58,19 @@ local schema = {
                 clock_skew = {
                     type = "integer",
                     default = 300
-                }
+                },
+                signed_headers = {
+                    type = "array",
+                    items = {
+                        type = "string",
+                        minLength = 1,
+                        maxLength = 20,

Review comment:
       The maxLength of 20 is not enough, how about 50?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org