You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by squito <gi...@git.apache.org> on 2018/02/15 15:43:08 UTC

[GitHub] spark pull request #17619: [SPARK-19755][Mesos] Blacklist is always active f...

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17619#discussion_r168509141
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ---
    @@ -484,7 +481,6 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
           cpus + totalCoresAcquired <= maxCores &&
           mem <= offerMem &&
           numExecutors() < executorLimit &&
    -      slaves.get(slaveId).map(_.taskFailures).getOrElse(0) < MAX_SLAVE_FAILURES &&
    --- End diff --
    
    rather than just deleting this, we should replace it with a check to `scheduler.nodeBlacklist()`, like the YarnScheduler is doing here: https://github.com/apache/spark/blob/44e20c42254bc6591b594f54cd94ced5fcfadae3/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala#L128


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org