[GitHub] activemq-artemis pull request #1725: ARTEMIS-1329 testNoLocalReconnect was f...

[stanlyDoge <gi...@git.apache.org>]

GitHub user stanlyDoge opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1725

    ARTEMIS-1329 testNoLocalReconnect was failing with OpenWire protocol

    Can anybody review this? This fixes the issue, but I find it weird to assign client ID to CID (connection ID) property. Although the same thing is done [here](https://github.com/apache/activemq-artemis/blob/master/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java#L83)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1329

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1725
    
----
commit 59418b8da5940748fed986d1a72f44f4313e16e2
Author: Stanislav Knot <sk...@redhat.com>
Date:   2017-12-18T11:28:30Z

    ARTEMIS-1329 testNoLocalReconnect was failing with OpenWire protocol

----


---

[GitHub] activemq-artemis issue #1725: ARTEMIS-1329 testNoLocalReconnect was failing ...

[mtaylor <gi...@git.apache.org>]

Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1725
  
    @clebertsuconic @stanlyDoge This commit has broken SimpleOpenWireTest.testTopicNoLocalDurable()
    
    Can you take a look please.


---

[GitHub] activemq-artemis pull request #1725: ARTEMIS-1329 testNoLocalReconnect was f...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1725


---