You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ko...@apache.org on 2021/01/18 00:41:02 UTC

[couchdb] 04/04: Parameterize the elixir version

This is an automated email from the ASF dual-hosted git repository.

kocolosk pushed a commit to branch 3.x-devcontainer
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit d6cc979f83400270cd2c0c4fe4df3736c297cb87
Author: Adam <ko...@apache.org>
AuthorDate: Sun Jan 17 19:36:06 2021 -0500

    Parameterize the elixir version
---
 .devcontainer/Dockerfile        |  4 ++--
 .devcontainer/devcontainer.json | 13 ++++++++++++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
index da4ea62..da9c55a 100644
--- a/.devcontainer/Dockerfile
+++ b/.devcontainer/Dockerfile
@@ -1,5 +1,5 @@
-# Based on erlang:22 (we need elixir for the test suite)
-FROM elixir:1.10
+ARG ELIXIR_VERSION
+FROM elixir:${ELIXIR_VERSION}
 
 # Use NodeSource binaries for Node.js (Fauxton dependency)
 RUN set -ex; \
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index d38d437..5207e52 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -1,6 +1,17 @@
 {
     "build": {
-        "dockerfile": "Dockerfile"
+        "dockerfile": "Dockerfile",
+        "args": {
+            // Useful choices include:
+            // 1.11 -> Erlang 23, Debian Buster
+            // 1.10 -> Erlang 22, Debian Buster
+            // 1.9  -> Erlang 22, Debian Buster
+            //
+            // Older versions based on Debian Stretch will not include
+            // SpiderMonkey 60, which the Dockerfile expects to be able
+            // to install via apt-get.
+            "ELIXIR_VERSION": "1.10"
+        }
     },
     "extensions": [
         "erlang-ls.erlang-ls"