[GitHub] [druid] capistrant commented on pull request #11257: Reduce method invocation of reservoir sampling

[GitBox <gi...@apache.org>]

capistrant commented on pull request #11257:
URL: https://github.com/apache/druid/pull/11257#issuecomment-858678690


   I haven't read the code yet, just reading comments and responding to my tag from @a2l007 ... I do think it is very helpful to keep the `percentOfSegmentsToConsider` value. Our largest cluster has over 2MM segments with replication and slashing that value down has allowed us to cut a large chunk out of coordination time in this phase by short circuiting at what we have deemed to be an acceptable point in the iteration. I'll try to read through full PR today and update my comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org