[GitHub] brodybits closed pull request #371: CI testing on Node.js versions 8 & 10

[GitBox <gi...@apache.org>]

brodybits closed pull request #371: CI testing on Node.js versions 8 & 10
URL: https://github.com/apache/cordova-ios/pull/371
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 013df38b7..d8fbb6f1f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,20 +1,26 @@
 language: objective-c
 osx_image: xcode9.2
 sudo: false
+
 env:
   matrix:
   - TRAVIS_NODE_VERSION: '4.8.7'
   - TRAVIS_NODE_VERSION: '6.13'
+  - TRAVIS_NODE_VERSION: '8'
+  - TRAVIS_NODE_VERSION: '10'
+
 before_install:
 - npm cache clean -f
 - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm
   && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm
   install $TRAVIS_NODE_VERSION
 - node --version
+
 install:
 - npm install
 - npm install ios-deploy
 - npm install -g codecov
+
 script:
     - npm run unit-tests
     - npm run e2e-tests
@@ -22,4 +28,6 @@ script:
     - npm run objc-tests
     - npm run cover
     - npm run eslint
-after_script: codecov
+
+after_script:
+    - codecov
diff --git a/appveyor.yml b/appveyor.yml
index c1b59528b..2a36faaa3 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -2,6 +2,8 @@ environment:
   matrix:
   - nodejs_version: "4"
   - nodejs_version: "6"
+  - nodejs_version: "8"
+  - nodejs_version: "10"
 
 install:
   - ps: Install-Product node $env:nodejs_version


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org