You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2024/11/22 10:00:33 UTC
[PR] @Component --> @Inject [maven-changes-plugin]
elharo opened a new pull request, #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44#issuecomment-2493463598
If we use `@` and something in commits, descriptions ... GitHub create a link to such account.
We should escape such words by ` , eg
```
`@Inject`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44#issuecomment-2493678690
I don't see any such links. I think it only autolinks in textboxes like this one, not everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44#issuecomment-2493720021
> I don't see any such links. I think it only autolinks in textboxes like this one, not everywhere
OK I do see one such link. However I still think we shouldn't change the general git commit message based on how Github will interpret it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44#discussion_r1853884742
##########
src/main/java/org/apache/maven/plugins/announcement/AnnouncementMojo.java:
##########
@@ -471,6 +460,22 @@ public class AnnouncementMojo extends AbstractAnnouncementMojo {
private ChangesXML xml;
+ /**
+ * Velocity Component.
+ */
+ private VelocityComponent velocity;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-434] @Component --> @Inject [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #44:
URL: https://github.com/apache/maven-changes-plugin/pull/44#discussion_r1853703812
##########
src/main/java/org/apache/maven/plugins/announcement/AnnouncementMojo.java:
##########
@@ -471,6 +460,22 @@ public class AnnouncementMojo extends AbstractAnnouncementMojo {
private ChangesXML xml;
+ /**
+ * Velocity Component.
+ */
+ private VelocityComponent velocity;
Review Comment:
final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org