[GitHub] andrzej-kaczmarek commented on a change in pull request #18: nimble/ll: Portion of fixes for the nimble controller.

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #18: nimble/ll: Portion of fixes for the nimble controller.
URL: https://github.com/apache/mynewt-nimble/pull/18#discussion_r177692703
 
 

 ##########
 File path: nimble/controller/src/ble_ll_ctrl.c
 ##########
 @@ -1599,6 +1599,16 @@ ble_ll_ctrl_rx_conn_param_req(struct ble_ll_conn_sm *connsm, uint8_t *dptr,
 {
     uint8_t rsp_opcode;
 
+    /* If Host masked out Remote Connection Parameter Request Event, we need to
+     * send Reject back to the remote device
+     */
+    if (!ble_ll_hci_is_le_event_enabled(BLE_HCI_LE_SUBEV_REM_CONN_PARM_REQ)){
 
 Review comment:
   masked event only matters if event should be indicated to host - you do not know this here. this should be added in `ble_ll_ctrl_conn_param_pdu_proc` - there's fixme comment regarding event masking there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services