You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HeartSaVioR (via GitHub)" <gi...@apache.org> on 2026/03/28 00:51:21 UTC

[PR] [SPARK-55729][SPARK-55630][SS][FOLLOWUP] Fix failing test due to dependencies of two changes [spark]

HeartSaVioR opened a new pull request, #55071:
URL: https://github.com/apache/spark/pull/55071

   ### What changes were proposed in this pull request?
   
   This PR proposes to fix the failing test introduced in SPARK-55729 due to the fact SPARK-55630 changes the behavior but misses to reflect the change to the test.
   
   ### Why are the changes needed?
   
   The new commit broke the test introduced by old commit.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   CI will follow.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude 4.6 Opus


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55729][SPARK-55630][SS][FOLLOWUP] Fix failing test due to dependencies of two changes [spark]

Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #55071:
URL: https://github.com/apache/spark/pull/55071#issuecomment-4146189867

   Let's wait for CI result. Due to recent compromising issue with LiteLLM, running tests in local requires some manual intervention. While this is specific to us, it should be OK as long as CI can run the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55729][SPARK-55630][SS][FOLLOWUP] Fix failing test due to dependencies of two changes [spark]

Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #55071: [SPARK-55729][SPARK-55630][SS][FOLLOWUP] Fix failing test due to dependencies of two changes
URL: https://github.com/apache/spark/pull/55071


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55729][SPARK-55630][SS][FOLLOWUP] Fix failing test due to dependencies of two changes [spark]

Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #55071:
URL: https://github.com/apache/spark/pull/55071#issuecomment-4147481137

   CI passes. Thanks! Merging to master. (And thanks for the patience!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org