[GitHub] [geode] agingade commented on a change in pull request #6042: GEODE-8958: When timestamps get corrupted.

[GitBox <gi...@apache.org>]

agingade commented on a change in pull request #6042:
URL: https://github.com/apache/geode/pull/6042#discussion_r582281070



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##########
@@ -423,8 +425,8 @@ protected void updateStatistics() {
     }
 
     @Override
-    protected boolean hasExpired(long msTillHeadTombstoneExpires) {
-      return msTillHeadTombstoneExpires <= 0;
+    protected boolean hasExpired(long msUntilTombstoneExpires) {
+      return msUntilTombstoneExpires <= 0;

Review comment:
       We may have to add the large clock jump verification here too...I am assuming clients are also doing Tombstone GC similarly....Nice to add a test on the client side to verify it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org