You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/08/10 06:23:26 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
panbingkun opened a new pull request, #42425:
URL: https://github.com/apache/spark/pull/42425
### What changes were proposed in this pull request?
The pr aims to add canonical links to the PySpark docs page.
### Why are the changes needed?
We should add the canonical link to the PySpark docs page https://spark.apache.org/docs/latest/api/python/index.html so that the search engine can return the latest PySpark docs.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual testing.
```
cd python/docs
make html
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1684304867
Hi @panbingkun, thanks for working on this! Can we also backport this to other released spark branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1683221401
I have checked the results and they are as follows
<img width="1110" alt="image" src="https://github.com/apache/spark/assets/15246973/70b75f06-380c-4503-9e52-6a46eb5c6921">
- The number of HTML files is: 2392
- The number of HTML files including `<link rel=\"canonical\" href=` is: 2318
- Excluding (2392 - 2318 = 74):
1._static/webpack-macros.html
```
<!--
All these macros are auto-generated and must **NOT** be edited by hand.
See the webpack.config.js file, to learn more about how this is generated.
-->
{% macro head_pre_icons() %}
<link rel="stylesheet"
href="{{ pathto('_static/vendor/fontawesome/5.13.0/css/all.min.css', 1) }}">
<link rel="preload" as="font" type="font/woff2" crossorigin
href="{{ pathto('_static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.woff2', 1) }}">
<link rel="preload" as="font" type="font/woff2" crossorigin
href="{{ pathto('_static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.woff2', 1) }}">
{% endmacro %}
{% macro head_pre_fonts() %}
{% endmacro %}
{% macro head_pre_bootstrap() %}
<link href="{{ pathto('_static/styles/theme.css', 1) }}?digest=1999514e3f237ded88cf" rel="stylesheet">
<link href="{{ pathto('_static/styles/pydata-sphinx-theme.css', 1) }}?digest=1999514e3f237ded88cf" rel="stylesheet">
{% endmacro %}
{% macro head_js_preload() %}
<link rel="preload" as="script" href="{{ pathto('_static/scripts/pydata-sphinx-theme.js', 1) }}?digest=1999514e3f237ded88cf">
{% endmacro %}
{% macro body_post() %}
<script src="{{ pathto('_static/scripts/pydata-sphinx-theme.js', 1) }}?digest=1999514e3f237ded88cf"></script>
{% endmacro %}
```
2.Taking 'reference/pyspark.pandas/api/pyspark-pandas-Series-hist-2.html' as an example, the content is as follows
```
<div> <script type="text/javascript">window.PlotlyConfig = {MathJaxConfig: 'local'};</script>
<script src="https://cdn.plot.ly/plotly-2.12.1.min.js"></script> <div id="107ab257-e553-4926-a005-b948862ed6f4" class="plotly-graph-div" style="height:100%; width:100%;"></div> <script type="text/javascript"> window.PLOTLYENV=window.PLOTLYENV || {}; if (document.getElementById("107ab257-e553-4926-a005-b948862ed6f4")) { Plotly.newPlot( "107ab257-e553-4926-a005-b948862ed6f4", [{"hovertemplate":"variable=one<br>value=%{text}<br>count=%{y}","name":"one","text":["[1.0, 1.916666667)","[1.916666667, 2.833333333)","[2.833333333, 3.75)","[3.75, 4.666666667)","[4.666666667, 5.583333333)","[5.583333333, 6.5)","[6.5, 7.416666667)","[7.416666667, 8.333333333)","[8.333333333, 9.25)","[9.25, 10.166666667)","[10.166666667, 11.083333333)","[11.083333333, 12.0]"],"x":[1.4583333333333333,2.375,3.2916666666666665,4.208333333333333,5.1
25,6.041666666666666,6.958333333333333,7.874999999999999,8.791666666666666,9.708333333333332,10.625,11.541666666666666],"y":[1044.0,1008.0,951.0,1005.0,968.0,1024.0,0.0,0.0,0.0,0.0,0.0,0.0],"type":"bar"},{"hovertemplate":"variable=two<br>value=%{text}<br>count=%{y}","name":"two","text":["[1.0, 1.916666667)","[1.916666667, 2.833333333)","[2.833333333, 3.75)","[3.75, 4.666666667)","[4.666666667, 5.583333333)","[5.583333333, 6.5)","[6.5, 7.416666667)","[7.416666667, 8.333333333)","[8.333333333, 9.25)","[9.25, 10.166666667)","[10.166666667, 11.083333333)","[11.083333333, 12.0]"],"x":[1.4583333333333333,2.375,3.2916666666666665,4.208333333333333,5.125,6.041666666666666,6.958333333333333,7.874999999999999,8.791666666666666,9.708333333333332,10.625,11.541666666666666],"y":[0.0,167.0,319.0,520.0,684.0,837.0,1011.0,817.0,645.0,491.0,328.0,181.0],"type":"bar"}], {"barmode":"stack","template":{"data":{"barpolar":[{"marker":{"line":{"color":"#E5ECF6","width":0.5},"pattern
":{"fillmode":"overlay","size":10,"solidity":0.2}},"type":"barpolar"}],"bar":[{"error_x":{"color":"#2a3f5f"},"error_y":{"color":"#2a3f5f"},"marker":{"line":{"color":"#E5ECF6","width":0.5},"pattern":{"fillmode":"overlay","size":10,"solidity":0.2}},"type":"bar"}],"carpet":[{"aaxis":{"endlinecolor":"#2a3f5f","gridcolor":"white","linecolor":"white","minorgridcolor":"white","startlinecolor":"#2a3f5f"},"baxis":{"endlinecolor":"#2a3f5f","gridcolor":"white","linecolor":"white","minorgridcolor":"white","startlinecolor":"#2a3f5f"},"type":"carpet"}],"choropleth":[{"colorbar":{"outlinewidth":0,"ticks":""},"type":"choropleth"}],"contourcarpet":[{"colorbar":{"outlinewidth":0,"ticks":""},"type":"contourcarpet"}],"contour":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"
#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"contour"}],"heatmapgl":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"heatmapgl"}],"heatmap":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"heatmap"}],"histogram2dcontour":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c17
9e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"histogram2dcontour"}],"histogram2d":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"histogram2d"}],"histogram":[{"marker":{"pattern":{"fillmode":"overlay","size":10,"solidity":0.2}},"type":"histogram"}],"mesh3d":[{"colorbar":{"outlinewidth":0,"ticks":""},"type":"mesh3d"}],"parcoords":[{"line":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"parcoords"}],"pie":[{"automargin":true,"type":"pie"}],"scatter3d":[{"line":{"colorbar":{"outlinewidth":0,"ticks":""}},"marker":{"colorbar":{"outlinewidth":0,"ticks":""}}
,"type":"scatter3d"}],"scattercarpet":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scattercarpet"}],"scattergeo":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scattergeo"}],"scattergl":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scattergl"}],"scattermapbox":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scattermapbox"}],"scatterpolargl":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scatterpolargl"}],"scatterpolar":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scatterpolar"}],"scatter":[{"fillpattern":{"fillmode":"overlay","size":10,"solidity":0.2},"type":"scatter"}],"scatterternary":[{"marker":{"colorbar":{"outlinewidth":0,"ticks":""}},"type":"scatterternary"}],"surface":[{"colorbar":{"outlinewidth":0,"ticks":""},"colorscale":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#
d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"type":"surface"}],"table":[{"cells":{"fill":{"color":"#EBF0F8"},"line":{"color":"white"}},"header":{"fill":{"color":"#C8D4E3"},"line":{"color":"white"}},"type":"table"}]},"layout":{"annotationdefaults":{"arrowcolor":"#2a3f5f","arrowhead":0,"arrowwidth":1},"autotypenumbers":"strict","coloraxis":{"colorbar":{"outlinewidth":0,"ticks":""}},"colorscale":{"diverging":[[0,"#8e0152"],[0.1,"#c51b7d"],[0.2,"#de77ae"],[0.3,"#f1b6da"],[0.4,"#fde0ef"],[0.5,"#f7f7f7"],[0.6,"#e6f5d0"],[0.7,"#b8e186"],[0.8,"#7fbc41"],[0.9,"#4d9221"],[1,"#276419"]],"sequential":[[0.0,"#0d0887"],[0.1111111111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]],"sequentialminus":[[0.0,"#0d0887"],[0.111111
1111111111,"#46039f"],[0.2222222222222222,"#7201a8"],[0.3333333333333333,"#9c179e"],[0.4444444444444444,"#bd3786"],[0.5555555555555556,"#d8576b"],[0.6666666666666666,"#ed7953"],[0.7777777777777778,"#fb9f3a"],[0.8888888888888888,"#fdca26"],[1.0,"#f0f921"]]},"colorway":["#636efa","#EF553B","#00cc96","#ab63fa","#FFA15A","#19d3f3","#FF6692","#B6E880","#FF97FF","#FECB52"],"font":{"color":"#2a3f5f"},"geo":{"bgcolor":"white","lakecolor":"white","landcolor":"#E5ECF6","showlakes":true,"showland":true,"subunitcolor":"white"},"hoverlabel":{"align":"left"},"hovermode":"closest","mapbox":{"style":"light"},"paper_bgcolor":"white","plot_bgcolor":"#E5ECF6","polar":{"angularaxis":{"gridcolor":"white","linecolor":"white","ticks":""},"bgcolor":"#E5ECF6","radialaxis":{"gridcolor":"white","linecolor":"white","ticks":""}},"scene":{"xaxis":{"backgroundcolor":"#E5ECF6","gridcolor":"white","gridwidth":2,"linecolor":"white","showbackground":true,"ticks":"","zerolinecolor":"white"},"yaxis":{"backgroundcolor":
"#E5ECF6","gridcolor":"white","gridwidth":2,"linecolor":"white","showbackground":true,"ticks":"","zerolinecolor":"white"},"zaxis":{"backgroundcolor":"#E5ECF6","gridcolor":"white","gridwidth":2,"linecolor":"white","showbackground":true,"ticks":"","zerolinecolor":"white"}},"shapedefaults":{"line":{"color":"#2a3f5f"}},"ternary":{"aaxis":{"gridcolor":"white","linecolor":"white","ticks":""},"baxis":{"gridcolor":"white","linecolor":"white","ticks":""},"bgcolor":"#E5ECF6","caxis":{"gridcolor":"white","linecolor":"white","ticks":""}},"title":{"x":0.05},"xaxis":{"automargin":true,"gridcolor":"white","linecolor":"white","ticks":"","title":{"standoff":15},"zerolinecolor":"white","zerolinewidth":2},"yaxis":{"automargin":true,"gridcolor":"white","linecolor":"white","ticks":"","title":{"standoff":15},"zerolinecolor":"white","zerolinewidth":2}}},"xaxis":{"title":{"text":"value"}},"yaxis":{"title":{"text":"count"}}}, {"responsive": true} ) };
</script> </div>
```
It is automatically generated using `https://github.com/apache/spark/blob/02a07cd6adc7f0674bc673e3f917d71d9b290199/python/pyspark/pandas/plot/core.py#L940` in Python files and is only used as an iframe on the page.
<img width="547" alt="image" src="https://github.com/apache/spark/assets/15246973/f14cc397-d9ad-4fbb-a56e-a88ae107cee2">
<img width="757" alt="image" src="https://github.com/apache/spark/assets/15246973/5e96ce87-2f61-4cb4-9cb9-758cb44f7280">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
URL: https://github.com/apache/spark/pull/42425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1753943908
@panbingkun thank you so much for working on this. It will be super helpful in improving the ranking for the PySpark documentations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1674135892
@panbingkun you may refer to https://docs.readthedocs.io/en/stable/canonical-urls.html to add canonical links to all pages automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1676614757
Alternatively, the following is also a solution, but the server configuration needs to be modified.
ref: https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls
<img width="913" alt="image" src="https://github.com/apache/spark/assets/15246973/c9f4e4d1-fa4c-4096-b355-cd1fbdf1fed6">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1672931546
@gatorsmile @allisonwang-db @allanf-db would you mind taking a look?
if this is the proper way, @panbingkun can help resolve other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1752261968
First, apply this to the active branch.
Branch 3.4: https://github.com/apache/spark/pull/43285
Branch 3.3: https://github.com/apache/spark/pull/43286
Then, I'll think about how to easily apply these changes to historical published documents.
@zhengruifeng @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrPowers commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "MrPowers (via GitHub)" <gi...@apache.org>.
MrPowers commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1682652629
@zhengruifeng - I don't know if adding a `html_baseurl` is enough. You'll need to test and make sure that all the pages properly generate canonical links when the setting is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1672628396
Before:
<img width="1294" alt="image" src="https://github.com/apache/spark/assets/15246973/6b121693-359d-4abc-b80b-1716cd2f8077">
After:
<img width="1230" alt="image" src="https://github.com/apache/spark/assets/15246973/f1fb295d-352e-435d-97f5-d1f0146ffaa2">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1683858842
merged to master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1672629071
cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrPowers commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "MrPowers (via GitHub)" <gi...@apache.org>.
MrPowers commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1673665711
Here is an example of a documentation page for a specific version: https://spark.apache.org/docs/3.1.3/api/python/reference/api/pyspark.sql.DataFrame.withColumn.html
This is the canonical link: https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.DataFrame.withColumn.html
All the "version pages" should have canonical links to the canonical page. Will this PR add canonical links to all the pages? How will we fix all the existing documentation pages that have already been published?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1676556063
> Here is an example of a documentation page for a specific version: https://spark.apache.org/docs/3.1.3/api/python/reference/api/pyspark.sql.DataFrame.withColumn.html
>
> This is the canonical link: https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.DataFrame.withColumn.html
>
> All the "version pages" should have canonical links to the canonical page. Will this PR add canonical links to all the pages? How will we fix all the existing documentation pages that have already been published?
In fact, the above settings have added `<link rel="canonical" href="...">` to all pages, but do not include which published documents. For published documents, there may be two options:
1. Cherry-Pick this pr to all branches and republish again.
2. Use a script to solve it.
Which one is better? @MrPowers @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42425: [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1681986692
@MrPowers according to the guide https://docs.readthedocs.io/en/stable/guides/canonical-urls.html#sphinx , it seems adding a `html_baseurl` in `conf.py` is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44729][PYTHON][DOCS] Add canonical links to the PySpark docs page [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42425:
URL: https://github.com/apache/spark/pull/42425#issuecomment-1752238913
> Hi @panbingkun, thanks for working on this! Can we also backport this to other released spark branches?
Okay, I only saw this comment today. I'm sorry.
Let me to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org