You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/05 17:14:41 UTC

[GitHub] [pulsar] Shawyeok opened a new issue, #19142: Subscription expiration mechanism should not delete __compaction subscription

Shawyeok opened a new issue, #19142:
URL: https://github.com/apache/pulsar/issues/19142

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   broker.conf
   ```
   brokerServiceCompactionMonitorIntervalInSeconds=60
   brokerServiceCompactionThresholdInBytes=0
   subscriptionExpirationTimeMinutes=4320
   subscriptionExpiryCheckIntervalInMinutes=5
   allowAutoSubscriptionCreation=false
   ```
   
   We are seeing logs below in our environment:
   ```
   2023-01-04T12:19:56.098Z [bookkeeper-ml-scheduler-OrderedScheduler-0-0] INFO org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://data/relation/__change_events-partition-2][__compaction] The subscription was deleted due to expiration
   
   2023-01-05T17:04:51.665Z [pulsar-io-4-5] WARN org.apache.pulsar.broker.service.ServerCnx - [/172.30.92.38:43186][persistent://z/job/__change_events-partition-0][__compaction] Failed to create consumer: consumerId=16444, Subscription does not exist
   2023-01-05T17:04:51.665Z [pulsar-io-4-4] WARN org.apache.pulsar.client.impl.ConsumerImpl - [persistent://z/job/__change_events-partition-0][__compaction] Failed to subscribe to topic on 172.30.92.38/172.30.92.38:6650
   ```
   
   ### Problems
   1. `__compaction` subscription was deleted by sub expiration mechanism
   2. `__compaction` subscription cannot re-create cause we disabled `allowAutoSubscriptionCreation`
   
   ### Solution
   
   1. Skip `__compaction` subscription in subscription cleanup process
   2. Allow `__compaction` sub auto creation even if `allowAutoSubscriptionCreation=false`
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #19142: Subscription expiration mechanism should not delete __compaction subscription

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19142:
URL: https://github.com/apache/pulsar/issues/19142#issuecomment-1416900456

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shawyeok closed issue #19142: Subscription expiration mechanism should not delete __compaction subscription

Posted by "Shawyeok (via GitHub)" <gi...@apache.org>.
Shawyeok closed issue #19142: Subscription expiration mechanism should not delete __compaction subscription
URL: https://github.com/apache/pulsar/issues/19142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shawyeok commented on issue #19142: Subscription expiration mechanism should not delete __compaction subscription

Posted by "Shawyeok (via GitHub)" <gi...@apache.org>.
Shawyeok commented on issue #19142:
URL: https://github.com/apache/pulsar/issues/19142#issuecomment-1729256467

   Fixed in https://github.com/apache/pulsar/pull/20983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org