You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/09 03:14:22 UTC
[GitHub] [skywalking-query-protocol] kezhenxu94 opened a new pull request #59: Replace size with pagination
kezhenxu94 opened a new pull request #59:
URL: https://github.com/apache/skywalking-query-protocol/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] kezhenxu94 merged pull request #59: Replace size with pagination
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #59:
URL: https://github.com/apache/skywalking-query-protocol/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #59: Replace size with pagination
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-query-protocol/pull/59#discussion_r666647784
##########
File path: event.graphqls
##########
@@ -60,7 +60,7 @@ input EventQueryCondition {
type: EventType
time: Duration
order: Order
- size: Int
Review comment:
I am good to remove. Wait for @Fine0830 to check what UI prefers, especially about the dashboard part change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull request #59: Replace size with pagination
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-query-protocol/pull/59#discussion_r666669357
##########
File path: event.graphqls
##########
@@ -60,7 +60,7 @@ input EventQueryCondition {
type: EventType
time: Duration
order: Order
- size: Int
Review comment:
Agree to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] kezhenxu94 commented on a change in pull request #59: Replace size with pagination
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-query-protocol/pull/59#discussion_r666642784
##########
File path: event.graphqls
##########
@@ -60,7 +60,7 @@ input EventQueryCondition {
type: EventType
time: Duration
order: Order
- size: Int
Review comment:
@wu-sheng @Fine0830 do you think we should keep this in protocol level or remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org