You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/05/15 20:52:09 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #738: DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QD…
ganeshmurthy opened a new pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738
…RC_EVENT_LINK_OUT_DETACHED events where the addr's edge_inlink and edge_outlink can be zeroed out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #738: DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QD…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #738: DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QD…
Posted by GitBox <gi...@apache.org>.
ted-ross commented on a change in pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738#discussion_r426624937
##########
File path: src/router_core/modules/edge_router/addr_proxy.c
##########
@@ -215,6 +215,50 @@ static void del_outlink(qcm_edge_addr_proxy_t *ap, qdr_address_t *addr)
}
}
+static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link)
+{
+ if (!link || !link->conn)
+ return;
+
+ //
+ // We only care if the link event is on an edge connection.
+ //
+ if (link->conn->role != QDR_ROLE_EDGE_CONNECTION)
+ return;
+
+ switch (event) {
+ case QDRC_EVENT_LINK_OUT_DETACHED: {
+ qdr_address_t *addr = link->owning_addr;
+ if (addr && addr->edge_outlink && link == addr->edge_outlink) {
Review comment:
The second condition in the if is technically not necessary. edge_outlink is never dereferenced, only compared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org