[GitHub] [druid] jasonk000 commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

[GitBox <gi...@apache.org>]

jasonk000 commented on pull request #12097:
URL: https://github.com/apache/druid/pull/12097#issuecomment-1000605742


   I like your suggestion to move it up to the interface level.
   
   WRT warn / error / etc. You're right; there's two perspectives on this:
   
   1. Yes, the biggest benefit is if logging is set to WARN/ERROR. In my stack, with thousands of tasks running, I specifically set warn level for this class in log4j xml as it is noisy, expensive and provides little benefit for regular operations, but this benefit is mitigated with the current codebase.
   
   2. Even in the case of info logging being enabled, the triple string concat is unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org