You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2025/10/11 05:53:45 UTC
[PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
zclllyybb opened a new pull request, #56825:
URL: https://github.com/apache/doris/pull/56825
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
According to [brpc doc](https://brpc.apache.org/docs/client/basics/#wait-for-completion-of-rpc),
> Calling Join(controller->call_id()) after completion of RPC is wrong, do save call_id before RPC, otherwise the controller may be deleted by done at any time.
now fixed it.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3393078590
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56825_ec23dd3afb4e118d41e36858956f98a97a6d213c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56825_ec23dd3afb4e118d41e36858956f98a97a6d213c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.18% (23552/33086) |
| Line Coverage | 57.60% (245765/426666) |
| Region Coverage | 52.64% (203702/386961) |
| Branch Coverage | 54.50% (87977/161414) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3446267697
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3392991981
<details>
<summary>TPC-DS: <b>Total hot run time: 190866 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec23dd3afb4e118d41e36858956f98a97a6d213c, data reload: false
query1 1086 439 412 412
query2 6562 1679 1704 1679
query3 6758 224 226 224
query4 26857 23479 22983 22983
query5 4848 633 486 486
query6 355 235 214 214
query7 4661 510 294 294
query8 302 265 272 265
query9 8728 2571 2589 2571
query10 538 346 288 288
query11 15518 15038 14897 14897
query12 196 125 119 119
query13 1692 551 433 433
query14 11511 9284 9384 9284
query15 201 204 177 177
query16 7683 684 520 520
query17 1221 755 609 609
query18 2036 435 391 391
query19 277 211 192 192
query20 151 133 130 130
query21 223 167 120 120
query22 4645 4787 4717 4717
query23 34714 33936 33751 33751
query24 8742 2499 2553 2499
query25 619 515 477 477
query26 853 299 188 188
query27 3004 521 387 387
query28 4385 2217 2171 2171
query29 785 647 670 647
query30 303 234 200 200
query31 949 832 785 785
query32 83 76 75 75
query33 588 409 347 347
query34 844 876 573 573
query35 856 871 783 783
query36 996 1031 936 936
query37 116 114 87 87
query38 3534 3533 3493 3493
query39 1471 1426 1522 1426
query40 223 128 123 123
query41 62 57 62 57
query42 121 111 111 111
query43 489 506 478 478
query44 1327 833 833 833
query45 191 178 177 177
query46 861 992 653 653
query47 1769 1788 1761 1761
query48 395 450 320 320
query49 744 515 413 413
query50 652 697 412 412
query51 3887 3927 3859 3859
query52 110 119 98 98
query53 243 272 207 207
query54 595 603 532 532
query55 94 83 86 83
query56 338 320 321 320
query57 1193 1262 1144 1144
query58 283 280 271 271
query59 2644 2608 2634 2608
query60 365 357 415 357
query61 154 153 147 147
query62 788 726 665 665
query63 235 197 196 196
query64 3599 1139 858 858
query65 4144 3978 3983 3978
query66 881 429 350 350
query67 15377 15316 15328 15316
query68 7827 882 598 598
query69 498 328 299 299
query70 1367 1283 1312 1283
query71 459 345 319 319
query72 5484 4864 4902 4864
query73 619 587 361 361
query74 9103 9125 8864 8864
query75 3484 3383 2839 2839
query76 3213 1175 795 795
query77 564 420 323 323
query78 9526 9794 8966 8966
query79 1904 855 615 615
query80 620 575 508 508
query81 513 255 226 226
query82 215 167 136 136
query83 273 290 252 252
query84 264 108 94 94
query85 846 452 417 417
query86 375 322 315 315
query87 3781 3779 3652 3652
query88 3345 2269 2256 2256
query89 398 326 311 311
query90 2035 234 231 231
query91 174 168 134 134
query92 93 73 66 66
query93 1897 984 648 648
query94 707 449 358 358
query95 432 344 329 329
query96 491 606 287 287
query97 2915 2989 2862 2862
query98 275 226 222 222
query99 1347 1436 1279 1279
Total cold run time: 275699 ms
Total hot run time: 190866 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3392955020
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3392955305
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #56825:
URL: https://github.com/apache/doris/pull/56825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3392996444
<details>
<summary>ClickBench: <b>Total hot run time: 29.95 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec23dd3afb4e118d41e36858956f98a97a6d213c, data reload: false
query1 0.06 0.04 0.05
query2 0.10 0.06 0.06
query3 0.25 0.09 0.09
query4 1.60 0.12 0.12
query5 0.28 0.26 0.24
query6 1.19 0.66 0.63
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.65 0.52 0.51
query10 0.59 0.57 0.57
query11 0.16 0.11 0.11
query12 0.16 0.12 0.12
query13 0.64 0.62 0.62
query14 1.05 1.05 1.01
query15 0.87 0.87 0.87
query16 0.41 0.39 0.39
query17 1.04 1.04 1.03
query18 0.22 0.20 0.20
query19 1.95 1.92 1.81
query20 0.01 0.02 0.01
query21 15.41 0.96 0.57
query22 0.76 1.23 0.70
query23 14.88 1.35 0.63
query24 7.29 1.37 0.33
query25 0.31 0.19 0.07
query26 0.61 0.17 0.13
query27 0.06 0.06 0.05
query28 8.83 1.38 0.93
query29 12.60 4.00 3.29
query30 0.29 0.13 0.12
query31 2.82 0.60 0.39
query32 3.26 0.55 0.48
query33 3.04 3.07 3.13
query34 16.08 5.42 4.91
query35 4.91 4.92 4.90
query36 0.68 0.53 0.50
query37 0.10 0.08 0.08
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.15
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 103.71 s
Total hot run time: 29.95 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3393020568
# BE UT Coverage Report
Increment line coverage `50.00% (1/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ec23dd3afb4e118d41e36858956f98a97a6d213c_ec23dd3afb4e118d41e36858956f98a97a6d213c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ec23dd3afb4e118d41e36858956f98a97a6d213c_ec23dd3afb4e118d41e36858956f98a97a6d213c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.50% (17729/33768) |
| Line Coverage | 37.68% (160936/427094) |
| Region Coverage | 32.21% (123091/382133) |
| Branch Coverage | 33.57% (53917/160603) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](brpc) Fix wrong usage of brpc call_id [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56825:
URL: https://github.com/apache/doris/pull/56825#issuecomment-3446267714
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org