You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/27 15:50:41 UTC
[GitHub] [flink] akalash opened a new pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
akalash opened a new pull request #17581:
URL: https://github.com/apache/flink/pull/17581
…mEnvironment to MiniClusterResource since it is not possible to configure it via StreamEnvironment
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This PR fixes the randomization of enabling buffer debloat in test*
## Brief change log
- *Moved randomization of buffer debloat from StreamEnvironment to MiniClusterResource since it is not possible to configure it via StreamEnvironment*
## Verifying this change
It is test feature
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
}, {
"hash" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26418",
"triggerID" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 889a4c1cfdf181aae5d53c721af40f6365e4fb42 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17581:
URL: https://github.com/apache/flink/pull/17581#discussion_r748153338
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java
##########
@@ -186,6 +190,12 @@ private void startMiniCluster() throws Exception {
configuration.setInteger(JobManagerOptions.PORT, 0);
configuration.setString(RestOptions.BIND_PORT, "0");
+ // randomize ITTests for enabling buffer de-bloating
+ if (RANDOMIZE_BUFFER_DEBLOAT_CONFIG
Review comment:
Yes, it is indeed a pity but since we can not configure the flink from one place so we can not randomize it from one place.
I will see what I can do for the explanation of the usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #17581:
URL: https://github.com/apache/flink/pull/17581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfba64bd7737705235c2fa279a31fb8ba951aa13 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048c520a40c4614b4d710ea958bb7cc273df2bd1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721)
* f633faa2fda3807d4600c1c99ab31e666c72c211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfba64bd7737705235c2fa279a31fb8ba951aa13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529)
* 048c520a40c4614b4d710ea958bb7cc273df2bd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
}, {
"hash" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26418",
"triggerID" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 920718119cc799dea2d8befab43a57134e4c2b52 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218)
* 889a4c1cfdf181aae5d53c721af40f6365e4fb42 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfba64bd7737705235c2fa279a31fb8ba951aa13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfba64bd7737705235c2fa279a31fb8ba951aa13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529)
* 048c520a40c4614b4d710ea958bb7cc273df2bd1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953066589
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dfba64bd7737705235c2fa279a31fb8ba951aa13 (Wed Oct 27 15:54:46 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 920718119cc799dea2d8befab43a57134e4c2b52 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
}, {
"hash" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "889a4c1cfdf181aae5d53c721af40f6365e4fb42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 920718119cc799dea2d8befab43a57134e4c2b52 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218)
* 889a4c1cfdf181aae5d53c721af40f6365e4fb42 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfba64bd7737705235c2fa279a31fb8ba951aa13 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17581:
URL: https://github.com/apache/flink/pull/17581#discussion_r747528336
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java
##########
@@ -186,6 +190,12 @@ private void startMiniCluster() throws Exception {
configuration.setInteger(JobManagerOptions.PORT, 0);
configuration.setString(RestOptions.BIND_PORT, "0");
+ // randomize ITTests for enabling buffer de-bloating
+ if (RANDOMIZE_BUFFER_DEBLOAT_CONFIG
Review comment:
It's a pity we need to randomize tests in two different places. Can we at least cross reference the two in a comment? We should also try to explain which place we should use for what class of options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048c520a40c4614b4d710ea958bb7cc273df2bd1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721)
* f633faa2fda3807d4600c1c99ab31e666c72c211 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f633faa2fda3807d4600c1c99ab31e666c72c211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133)
* 920718119cc799dea2d8befab43a57134e4c2b52 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048c520a40c4614b4d710ea958bb7cc273df2bd1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f633faa2fda3807d4600c1c99ab31e666c72c211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17581:
URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25529",
"triggerID" : "dfba64bd7737705235c2fa279a31fb8ba951aa13",
"triggerType" : "PUSH"
}, {
"hash" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25721",
"triggerID" : "048c520a40c4614b4d710ea958bb7cc273df2bd1",
"triggerType" : "PUSH"
}, {
"hash" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133",
"triggerID" : "f633faa2fda3807d4600c1c99ab31e666c72c211",
"triggerType" : "PUSH"
}, {
"hash" : "920718119cc799dea2d8befab43a57134e4c2b52",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218",
"triggerID" : "920718119cc799dea2d8befab43a57134e4c2b52",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f633faa2fda3807d4600c1c99ab31e666c72c211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26133)
* 920718119cc799dea2d8befab43a57134e4c2b52 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26218)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17581:
URL: https://github.com/apache/flink/pull/17581#discussion_r748310871
##########
File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -87,43 +85,44 @@ public static void setAsContext(
new TestStreamEnvironment(
miniCluster, parallelism, jarFiles, classpaths);
- // randomize ITTests for enabling unaligned checkpoint
- if (RANDOMIZE_CHECKPOINTING_CONFIG) {
- randomize(
- conf, ExecutionCheckpointingOptions.ENABLE_UNALIGNED, true, false);
- randomize(
- conf,
- ExecutionCheckpointingOptions.ALIGNMENT_TIMEOUT,
- Duration.ofSeconds(0),
- Duration.ofMillis(100),
- Duration.ofSeconds(2));
- }
-
- // randomize ITTests for enabling state change log
- if (isConfigurationSupportedByChangelog(miniCluster.getConfiguration())) {
- if (STATE_CHANGE_LOG_CONFIG.equalsIgnoreCase(STATE_CHANGE_LOG_CONFIG_ON)) {
- conf.set(StateChangelogOptions.ENABLE_STATE_CHANGE_LOG, true);
- } else if (STATE_CHANGE_LOG_CONFIG.equalsIgnoreCase(
- STATE_CHANGE_LOG_CONFIG_RAND)) {
- randomize(
- conf,
- StateChangelogOptions.ENABLE_STATE_CHANGE_LOG,
- true,
- false);
- }
- }
-
- // randomize ITTests for enabling buffer de-bloating
- if (RANDOMIZE_BUFFER_DEBLOAT_CONFIG) {
- randomize(conf, TaskManagerOptions.BUFFER_DEBLOAT_ENABLED, true, false);
- }
+ randomizeConfiguration(miniCluster, conf);
+
env.configure(conf, env.getUserClassloader());
return env;
};
initializeContextEnvironment(factory);
}
+ /**
+ * This is the place for randomization the configuration that relates to DataStream API such as
+ * ExecutionConf, CheckpointConf, StreamExecutionEnvironment. List of the configurations can be
+ * found here {@link StreamExecutionEnvironment#configure(ReadableConfig, ClassLoader)}. All
+ * other configuration should be randomized here {@link
+ * org.apache.flink.runtime.testutils.MiniClusterResource#randomizeConfiguration(Configuration)}.
+ */
+ private static void randomizeConfiguration(MiniCluster miniCluster, Configuration conf) {
Review comment:
Thanks for the comments! I think they will be helpful for people who get to this point in the future!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org