DO NOT REPLY [Bug 17130] New: - Reusing tags doesn't calls reuse before cache tag is used

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17130>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17130

Reusing tags doesn't calls reuse before cache tag is used

           Summary: Reusing tags doesn't calls reuse before cache tag is
                    used
           Product: Tomcat 4
           Version: 4.1.20
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Jasper 2
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: vicentesalvador@netscape.net


Look at TagHandlerPool.java
Method resuse should call always the release method of the tag, if not the
variables of the class are not initialized and if the tag is used from the
cache, release is never called.

This has been tested on an "tag intensive application". Please patch it for
4.1.21. Next I inclose how the reuse method of TagHandlerPool should be:


public synchronized void reuse(Tag handler) {
	if (current < (handlers.length - 1))
	    handlers[++current] = handler;
// Why else ?, always release resources and prepare for next use
//	else
	    handler.release();
}

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org