You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2024/04/15 10:52:18 UTC
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21300
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 41 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/1
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21300
to look at the new patch set (#4).
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 52 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/4
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/13/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:23:23 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21300
to look at the new patch set (#5).
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
The addition of monitoring items will aid in historical issue
tracking and analysis, as well as facilitate the configuration
of monitoring alarms.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 49 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/5
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 May 2024 02:33:05 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/10/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Apr 2024 11:38:26 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21300
to look at the new patch set (#3).
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 55 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/3
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc
File src/kudu/tablet/ops/alter_schema_op.cc:
http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc@158
PS4, Line 158: auto update_metrics = [this]() {
How about making it as a ScopedCleanup, then you don't need to call it manually in every return.
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 03:10:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 6:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/139/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2024 02:55:13 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/68/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2024 12:35:27 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc
File src/kudu/tablet/ops/alter_schema_op.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc@179
PS2, Line 179: uint64_t op_duration_usec = (MonoTime::Now() - start_time_).ToMicroseconds();
1. Should this metric also statistics the duraction when the ops aborted (line 159)?
2. How aboud using ScopedLatencyMetric to simplify the code?
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc
File src/kudu/tablet/tablet_metrics.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc@227
PS2, Line 227:
nit: Leave one blank line is enough.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc
File src/kudu/tablet/tablet_replica-test.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@267
PS2, Line 267: SchemaPB orig_schema_pb;
Is 'orig_schema_pb' necessary?
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@272
PS2, Line 272: scoped_refptr<Histogram> alter_schema_duration =
: METRIC_alter_schema_duration.Instantiate(tablet_replica_->tablet()->GetMetricEntity());
Is it possible to get the metric via tablet_replica_->tablet()->metrics()->alter_schema_duration?
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@274
PS2, Line 274: auto before_cnt = alter_schema_duration->TotalCount();
nit: add 'const'
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@279
PS2, Line 279: Schema new_client_schema = builder.BuildWithoutIds();
Is 'new_client_schema' necessary?
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@285
PS2, Line 285: LOG(INFO) << "Tablet alter schema histogram";
: alter_schema_duration->histogram()->DumpHumanReadable(&LOG(INFO));
Is this debugging purpose only? Remove it if not necessary, check the metric changes in line 284 is enough.
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 03:09:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/13/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 07:18:33 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/61/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2024 08:57:39 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 3:
(7 comments)
Thanks for your reviews.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc
File src/kudu/tablet/ops/alter_schema_op.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc@179
PS2, Line 179: DCHECK_EQ(result, Op::APPLIED);
> 1. Should this metric also statistics the duraction when the ops aborted (l
1.done
2.The scope of ScopedLatencyMetric is limited and not quite suitable here; I will use a lambda function to achieve a similar functionality.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc
File src/kudu/tablet/tablet_metrics.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc@227
PS2, Line 227: METRIC_DEFINE_histogram(tablet, alter_schema_duration,
> nit: Leave one blank line is enough.
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc
File src/kudu/tablet/tablet_replica-test.cc:
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@267
PS2, Line 267: const int orig_schema_version = tablet()->metadata()->schema_version();
> Is 'orig_schema_pb' necessary?
Removed.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@272
PS2, Line 272: const auto before_cnt = alter_schema_duration->TotalCount();
:
> Is it possible to get the metric via tablet_replica_->tablet()->metrics()->
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@274
PS2, Line 274: // Add a new column.
> nit: add 'const'
Done
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@279
PS2, Line 279: ASSERT_OK(UpdateSchema(new_schema, orig_schema_version + 1));
> Is 'new_client_schema' necessary?
Removed.
http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@285
PS2, Line 285: TEST_F(TabletReplicaTest, TestMRSAnchorPreventsLogGC) {
: ConsensusBootstrapInfo info;
> Is this debugging purpose only? Remove it if not necessary, check the metri
Done
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:24:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/68/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2024 14:43:55 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4:
(1 comment)
Thanks for your reviews.
http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc
File src/kudu/tablet/ops/alter_schema_op.cc:
http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc@158
PS4, Line 158: auto update_metrics = [this]() {
> How about making it as a ScopedCleanup, then you don't need to call it manu
Done
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 10:46:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/137/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 10:46:01 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/10/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Apr 2024 09:50:24 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
The addition of monitoring items will aid in historical issue
tracking and analysis, as well as facilitate the configuration
of monitoring alarms.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Reviewed-on: http://gerrit.cloudera.org:8080/21300
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 49 insertions(+), 1 deletion(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2024 11:50:21 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/139/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2024 03:57:59 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 56 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/2
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/137/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 12:07:18 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21300
to look at the new patch set (#6).
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
[metrics] Add tablet level metrics for alter schema op time
Add tablet-level statistics to track the time consumption of
alter schema operations.
The addition of monitoring items will aid in historical issue
tracking and analysis, as well as facilitate the configuration
of monitoring alarms.
Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
---
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
5 files changed, 49 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/21300/6
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [metrics] Add tablet level metrics for alter schema op time
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/61/
--
To view, visit http://gerrit.cloudera.org:8080/21300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a
Gerrit-Change-Number: 21300
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2024 04:17:05 +0000
Gerrit-HasComments: No