You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/06/17 22:39:29 UTC

[GitHub] [zookeeper] suhasdantkale opened a new pull request #990: Suhas/master mtls support

suhasdantkale opened a new pull request #990: Suhas/master mtls support
URL: https://github.com/apache/zookeeper/pull/990
 
 
   There is an original PR opened for this by @SHUOSHI and reviewed by @anmolnar -
   #639
   This PR picks up those changes and fixes following bugs and design issues:
   
   1. OPENSSL 1.0.2 version support:
   PR#639 doesn't take care of any version of openssl less than 1.1.1.
   2. SSL connection on non-blocking socket is handled correctly.
   PR#639 starts the ZK protocol(prime_connection()) before establishing the SSL connection.
   This leads to the connection failures sometimes.
   3. Certificate Chain:
   With clients cert chain(the intermediate certs), PR#639 doesn't work.
   4. Memory Leaks
   5. Generated Test certs: PR#639 had pre-generated certs pushed inside the repo. This change generated the certs dynamically.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services