You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 06:58:15 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5331: sched/critmonitor: remove the assertion if counter == 0
anchao opened a new pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331
## Summary
sched/critmonitor: remove the assertion if counter == 0
## Impact
N/A
## Testing
critmon perf test on Cortex-m55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791459952
##########
File path: sched/sched/sched_critmonitor.c
##########
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save the start time */
tcb->premp_start = current;
- DEBUGASSERT(tcb->premp_start != 0);
Review comment:
@pkarashchenko
Perf timer interface generally uses the hardware cycle counter
provided by the arch chip directly(such as DWT_CYCCNT(cortex-m)),
CYCCNT is a free running counter and counting upwards.
It wraps around to 0 on overflow.
I have update the description on commit message, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791427199
##########
File path: sched/sched/sched_critmonitor.c
##########
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save the start time */
tcb->premp_start = current;
- DEBUGASSERT(tcb->premp_start != 0);
Review comment:
Do we know why assertion is here and why it is removed?
The PR description does not reflect this info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791427199
##########
File path: sched/sched/sched_critmonitor.c
##########
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save the start time */
tcb->premp_start = current;
- DEBUGASSERT(tcb->premp_start != 0);
Review comment:
Do we know why assertion is here and why it is removed?
The PR description does not reflect this info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5331: sched/critmonitor: remove the assertion if counter == 0
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791459952
##########
File path: sched/sched/sched_critmonitor.c
##########
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save the start time */
tcb->premp_start = current;
- DEBUGASSERT(tcb->premp_start != 0);
Review comment:
@pkarashchenko
Perf timer interface generally uses the hardware cycle counter
provided by the arch chip directly(such as DWT_CYCCNT(cortex-m)),
CYCCNT is a free running counter and counting upwards.
It wraps around to 0 on overflow.
I have update the description on commit message, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org