You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by kb...@apache.org on 2017/03/03 13:22:49 UTC
incubator-atlas git commit: ATLAS-1605 Edit Entity in UI : Update
button is not enabled when updating attribute of type date
Repository: incubator-atlas
Updated Branches:
refs/heads/master 9e578251a -> 7753f2e86
ATLAS-1605 Edit Entity in UI : Update button is not enabled when updating attribute of type date
Project: http://git-wip-us.apache.org/repos/asf/incubator-atlas/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/7753f2e8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-atlas/tree/7753f2e8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-atlas/diff/7753f2e8
Branch: refs/heads/master
Commit: 7753f2e869b32104cf992722b11fef82fe5b5655
Parents: 9e57825
Author: kevalbhatt <kb...@apache.org>
Authored: Fri Mar 3 18:52:06 2017 +0530
Committer: kevalbhatt <kb...@apache.org>
Committed: Fri Mar 3 18:52:06 2017 +0530
----------------------------------------------------------------------
.../public/js/views/entity/CreateEntityLayoutView.js | 14 +++++++++-----
release-log.txt | 1 +
2 files changed, 10 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/7753f2e8/dashboardv2/public/js/views/entity/CreateEntityLayoutView.js
----------------------------------------------------------------------
diff --git a/dashboardv2/public/js/views/entity/CreateEntityLayoutView.js b/dashboardv2/public/js/views/entity/CreateEntityLayoutView.js
index 21db8f8..0206491 100644
--- a/dashboardv2/public/js/views/entity/CreateEntityLayoutView.js
+++ b/dashboardv2/public/js/views/entity/CreateEntityLayoutView.js
@@ -167,9 +167,6 @@ define(['require',
}
});
- if (this.guid) {
- this.bindNonRequiredField();
- }
this.ui.entityInputData.on('keyup change dp.change', 'input.true,select.true', function(e) {
if (this.value !== "") {
if ($(this).data('select2')) {
@@ -200,7 +197,7 @@ define(['require',
},
bindNonRequiredField: function() {
var that = this;
- this.ui.entityInputData.off('keyup change', 'input.false,select.false').on('keyup change', 'input.false,select.false', function(e) {
+ this.ui.entityInputData.off('keyup change dp.change', 'input.false,select.false').on('keyup change dp.change', 'input.false,select.false', function(e) {
if (that.modal.$el.find('button.ok').prop('disabled') && that.ui.entityInputData.find('.errorClass').length === 0) {
that.modal.$el.find('button.ok').prop("disabled", false);
}
@@ -350,11 +347,14 @@ define(['require',
});
}
});
+ if (this.guid) {
+ this.bindNonRequiredField();
+ }
this.initializeValidation();
-
if (this.ui.entityInputData.find('fieldset').length > 0 && this.ui.entityInputData.find('select.true,input.true').length === 0) {
this.requiredAllToggle(this.ui.entityInputData.find('select.true,input.true').length === 0);
if (!this.guid) {
+ // For create entity bind keyup for non-required field when all elements are optional
this.bindNonRequiredField();
}
this.ui.toggleRequired.prop('checked', true);
@@ -405,6 +405,10 @@ define(['require',
this.$('input[data-type="long"],input[data-type="int"]').on('keyup click', function(e) {
removeText(e, e.currentTarget.value);
});
+
+ this.$('input[data-type="date"]').on('dp.hide', function() {
+ this.blur();
+ });
},
getContainer: function(value) {
var entityLabel = this.capitalize(value.name);
http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/7753f2e8/release-log.txt
----------------------------------------------------------------------
diff --git a/release-log.txt b/release-log.txt
index b36724f..d9bafd6 100644
--- a/release-log.txt
+++ b/release-log.txt
@@ -9,6 +9,7 @@ ATLAS-1060 Add composite indexes for exact match performance improvements for al
ATLAS-1127 Modify creation and modification timestamps to Date instead of Long(sumasai)
ALL CHANGES:
+ATLAS-1605 Edit Entity in UI : Update button is not enabled when updating attribute of type date (Kalyanikashikar via kevalbhatt)
ATLAS-1595:Create Entity in UI : All attributes are not listed for hdfs_path. (Kalyanikashikar via kevalbhatt)
ATLAS-1618: updated export to support scope option - full/connected
ATLAS-1621: fixed webapp integration tests failures