You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:49:05 UTC

[GitHub] [spark] sarutak commented on pull request #32892: [SPARK-35737][SQL] Parse day-time interval literals to tightest types

sarutak commented on pull request #32892:
URL: https://github.com/apache/spark/pull/32892#issuecomment-860265038


   > Please, open a sub-task in JIRA to don't forget about it if it is hard to do in this PR.
   
   Yes, I've noticed that we should support single field but single field is currently parsed as `CalendarIntervalType` so we need change the behavior. So I separated that from this issue.
   Sure, I'll open a sub task.
   
   BTW, what do you think of multiple fields like `1 day 2 hours`? They should be parsed as `DayTimeIntervalType` rather than `CalendarType`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org