You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aaron-ai (via GitHub)" <gi...@apache.org> on 2024/04/16 08:51:32 UTC
[PR] KAFKA-16561 Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
aaron-ai opened a new pull request, #15728:
URL: https://github.com/apache/kafka/pull/15728
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066221145
KIP has been created here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1039%3A+Disable+automatic+topic+creation+for+MirrorMaker2+consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1569197938
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -169,6 +170,7 @@ static Map<String, Object> sourceConsumerConfig(Map<String, ?> props) {
result.putAll(Utils.entriesWithPrefix(props, CONSUMER_CLIENT_PREFIX));
result.putAll(Utils.entriesWithPrefix(props, SOURCE_PREFIX + CONSUMER_CLIENT_PREFIX));
result.put(ENABLE_AUTO_COMMIT_CONFIG, "false");
+ result.put(ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");
Review Comment:
While this may be more ideal for many use cases, it's a potentially-breaking change that I don't believe we can make without waiting for a major release (right now, that'd be 4.0.0), and an accepted KIP. If you're unfamiliar with the KIP process, you can read more about it here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2061493764
Hi @aaron-ai thanks for the PR. Can you please have a look into the failing tests herehttps://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15728/1/#showFailuresLink I believe they are related for example
[MirrorConnectorConfigTest]( https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15728/1/testReport/junit/org.apache.kafka.connect.mirror/MirrorConnectorConfigTest/Build___JDK_21_and_Scala_2_13___testSourceConsumerConfigWithSourcePrefix__/) is failing with
```
org.opentest4j.AssertionFailedError: source.consumer. source consumer config not matching ==> expected: <{enable.auto.commit=false, max.poll.interval.ms=100, auto.offset.reset=latest, client.id=source1->target2|ConnectorName|test}> but was: <{enable.auto.commit=false, max.poll.interval.ms=100, allow.auto.create.topics=false, auto.offset.reset=latest, client.id=source1->target2|ConnectorName|test}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2571488667
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1572155918
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -169,6 +170,7 @@ static Map<String, Object> sourceConsumerConfig(Map<String, ?> props) {
result.putAll(Utils.entriesWithPrefix(props, CONSUMER_CLIENT_PREFIX));
result.putAll(Utils.entriesWithPrefix(props, SOURCE_PREFIX + CONSUMER_CLIENT_PREFIX));
result.put(ENABLE_AUTO_COMMIT_CONFIG, "false");
+ result.put(ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");
Review Comment:
@aaron-ai thanks for drafting a KIP that quickly. I left a couple of comments there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2297941272
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1569813058
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -169,6 +170,7 @@ static Map<String, Object> sourceConsumerConfig(Map<String, ?> props) {
result.putAll(Utils.entriesWithPrefix(props, CONSUMER_CLIENT_PREFIX));
result.putAll(Utils.entriesWithPrefix(props, SOURCE_PREFIX + CONSUMER_CLIENT_PREFIX));
result.put(ENABLE_AUTO_COMMIT_CONFIG, "false");
+ result.put(ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");
Review Comment:
@C0urante OK, I will draft a KIP later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15728: KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config
URL: https://github.com/apache/kafka/pull/15728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066276867
> Thanks for getting the KIP out there for discussion and for fixing the tests. Should this PR be a draft until we have the KIP voted in by the community?
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]
Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15728:
URL: https://github.com/apache/kafka/pull/15728#issuecomment-2066275194
Thanks for getting the KIP out there for discussion and for fixing the tests. Should this PR be a draft until we have the KIP voted in by the community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org