You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/01/11 18:19:53 UTC

[PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

seekskyworld opened a new pull request, #21292:
URL: https://github.com/apache/kafka/pull/21292

   ## Summary
   - wait for the async InvalidTopicException instead of a single poll
   
   ## Motivation
   - eliminate flakiness in ShareConsumerTest.testSubscribeOnInvalidTopicThrowsInvalidTopicException (KAFKA-19962)
   
   ## Validation
   - ./gradlew :clients:clients-integration-tests:test --tests org.apache.kafka.clients.consumer.ShareConsumerTest.testSubscribeOnInvalidTopicThrowsInvalidTopicException
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #21292:
URL: https://github.com/apache/kafka/pull/21292#issuecomment-3758999295

   @seekskyworld Thanks for the PR, but I don't think it's necessary since #21239. If I look at develocity, I only see a failure on the 4.2 branch which does not have that PR. If I run locally, I can run 200 iterations with no failures. Looking at the existing test and the modified test in this PR, they aren't quite doing the same thing. The existing test waits in `poll(Duration)` until the exception is thrown, and I think we should retain a test for that logic. As a result, I think we should close this PR. Thanks for all the effort, but I feel this PR is no longer needed.
   
   `testPollThrowsInterruptExceptionIfInterrupted` does however fail. If you're interested in fixing that one, I'd be very grateful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #21292:
URL: https://github.com/apache/kafka/pull/21292#issuecomment-3738910522

   @seekskyworld Looks like the build failed with a compile error. Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield closed pull request #21292: KAFKA-19962: Stabilize ShareConsumer invalid-topic test
URL: https://github.com/apache/kafka/pull/21292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #21292:
URL: https://github.com/apache/kafka/pull/21292#issuecomment-3737808572

   Thanks for the PR. I note that this test has been reliable for 2 weeks now without this PR. The test flakiness looks like it was due to a failure to close the group cleanly which was fixed by https://github.com/apache/kafka/pull/21239. I will evaluate whether this fix is necessary in the presence of the PR I mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on PR #21292:
URL: https://github.com/apache/kafka/pull/21292#issuecomment-3737865185

   You may consider merging this request, as it will make the code more robust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19962: Stabilize ShareConsumer invalid-topic test [kafka]

Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on PR #21292:
URL: https://github.com/apache/kafka/pull/21292#issuecomment-3743909231

   @AndrewJSchofield Thanks — I’ve resubmitted the PR and fixed the compile error.
   
   I’ve reviewed the code again, and I believe the change is still valuable as a defensive improvement even with #21239 in place.
   
   Happy to close or adjust it if you feel it’s no longer needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org